This repository was archived by the owner on Dec 17, 2019. It is now read-only.
Rudy/master updated #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defaults: all check results since 1970, at most 100 results
Conflicts: pingdom/connection.py
Dropped Python 2.5 support
Conflicts: docs/usage.rst pingdom/__init__.py pingdom/connection.py pingdom/exception.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged the tip of the original repo into our branch, and resolved the merge conflicts so that our code doesn't have to be changed, but that makes it different from the main repo because they put some backwards incompatible changes.
It made the switch from urllib2 to provide the connection to requests (so urllib3 inside).
On top of that, I changed the connection to pingdom api to use a request.Session instead of simple requests request which allows to cache the connection and give a small speed boost.
From a profile run from our crawler, that spends most of the time doing the http calls:
Before:
After:
516/520 is the number of times the http cales are made. 495/370 is the cumulative time spent doing them.