Merged
Conversation
…f the 'type_' attribute of the path parameter ModelField instance; 'type_' is a Pydantic v1 attribute that has been removed
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
==========================================
- Coverage 46.65% 46.64% -0.01%
==========================================
Files 91 91
Lines 9607 9615 +8
Branches 1255 1258 +3
==========================================
+ Hits 4482 4485 +3
- Misses 4912 4915 +3
- Partials 213 215 +2 🚀 New features to boost your workflow:
|
d-j-hatton
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent FastAPI version update (around v0.128.3/4) broke the
generate_route_manifestCLI. We previously extracted a URL endpoint path parameter's type information from thetype_attribute in the path parameterModelFieldinstance, which has been removed in said recent FastAPI version update. Further inspection indicates that it is a Pydantic v1 attribute, and has been phased out as part of deprecating Pydantic v1.This PR replaces the use of the
type_attribute with the Pydantic v2_type_adapter._typeattribute, which contains the full type annotation of the path parameter. A helper function was introduced to extract the basic Python type from the annotation.