Skip to content

Conversation

@tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Feb 11, 2026

The code works, but Pylance flagged some issues with the way in which the functions were type hinted and the errors were raised. This PR resolves those issues by type hinting and handling errors correctly.

  • Use SQLModel and SQLALchemy's respective implementations of select
  • Set default value of lookup_kwargs and insert_kwargs to None, then create the empty dictionary within the function.
  • raise InterfaceError is not needed
  • Use SessionTransaction for type hinting instead of RootTransaction

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.65%. Comparing base (8fb34a2) to head (4358e3f).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #741   +/-   ##
=======================================
  Coverage   46.65%   46.65%           
=======================================
  Files          91       91           
  Lines        9607     9607           
  Branches     1255     1255           
=======================================
  Hits         4482     4482           
  Misses       4912     4912           
  Partials      213      213           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin self-assigned this Feb 11, 2026
@tieneupin tieneupin added the bug Something isn't working label Feb 11, 2026
@tieneupin tieneupin changed the title Fixed incorrect typing issues in the 'conftest' test module that were revealed by Pylance Fixed typing issues in the 'conftest' test module that were revealed by Pylance Feb 11, 2026
@tieneupin tieneupin merged commit db351d1 into main Feb 11, 2026
17 checks passed
@tieneupin tieneupin deleted the fix-database-conftest-functions branch February 11, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants