Add navbar tests, fix Jest/Babel configs#25
Merged
gfrn merged 7 commits intoDiamondLightSource:mainfrom Jan 21, 2025
Merged
Conversation
Jest was declared as a module, but had no default export, this makes the Jest config a module. Babel has been made CommonJS, as it is the standard with this version of Babel
Collaborator
VictoriaBeilsten-Edmands
left a comment
VictoriaBeilsten-Edmands
left a comment
There was a problem hiding this comment.
Thanks for adding these tests and for the config updates.
As we've got rid of "type": "module" in package.json do we still need to change babel.config.js to babel.config.cjs?
Collaborator
Author
|
I based this off an older master branch, but I'll test it without |
Collaborator
Author
|
That should do it, but it's not wholly necessary - it still uses CJS module exports than proper |
VictoriaBeilsten-Edmands
approved these changes
Jan 20, 2025
Collaborator
VictoriaBeilsten-Edmands
left a comment
VictoriaBeilsten-Edmands
left a comment
There was a problem hiding this comment.
Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next, I think I'll add workflow actions for automatically running unit tests, and possible move to Vitest!