Implement parameters handling in dynamic routes#84158
Draft
collectioneur wants to merge 7 commits intoExpensify:mainfrom
Draft
Implement parameters handling in dynamic routes#84158collectioneur wants to merge 7 commits intoExpensify:mainfrom
collectioneur wants to merge 7 commits intoExpensify:mainfrom
Conversation
…ponents, and updating navigation dynamic routes logic.
…tioneur/dynamic-routes-parameters-handling
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
39a53ba to
a55b125
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Add query parameter support to dynamic routes. Previously, dynamic suffixes couldn't include query params (e.g.,
country?country=US). This extendsDynamicRouteConfigwith an optionalgetRoutefunction, refactorscreateDynamicRouteto merge base and suffix query strings, and updatesgetPathWithoutDynamicSuffixto strip suffix-specific params. MigratesSETTINGS_ADDRESS_COUNTRYfrom a static route to the newADDRESS_COUNTRYdynamic route as a proof of concept.Fixed Issues
$ #84119
Tests
1 test
2 test
3 test
settings/profile/address/country?country=USOffline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-03-06.at.17.22.34.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-03-06.at.16.51.33.mov