[HOLD BE] Fix: Change #admins room message when someone joins via link#84159
Draft
dominictb wants to merge 5 commits intoExpensify:mainfrom
Draft
[HOLD BE] Fix: Change #admins room message when someone joins via link#84159dominictb wants to merge 5 commits intoExpensify:mainfrom
#admins room message when someone joins via link#84159dominictb wants to merge 5 commits intoExpensify:mainfrom
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
…ix/change-message-when-user-joins-via-link
#admins room message when someone joins via link#admins room message when someone joins via link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When someone joins a policy via the policy join link with
autoJoinenabled, the message in#adminsroom says the policy owner added that person. We need to update the report action to:notifications@expensify.com, not the admin, be the actor (Auth https://github.com/Expensify/Auth/pull/20231)#adminsroom message when someone joins via link #84159)Such scenario is indicated by the
didJoinPolicyflag.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/604683
PROPOSAL:
Tests
Preconditions:
Pre-approve join requests from validated users at...Auto join
#adminsroom[email] joined via workspace joining linknotifications@expensify.comNon-auto join
#adminsroomAcceptadded ... as a memberManual invite
#adminsroomadded ... as a memberOffline tests
NA
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-03-05.at.23.50.13-compressed.mov