[No QA] Handle too_large diff error in generateTranslations workflow#84175
Merged
mjasikowski merged 2 commits intomainfrom Mar 5, 2026
Merged
[No QA] Handle too_large diff error in generateTranslations workflow#84175mjasikowski merged 2 commits intomainfrom
mjasikowski merged 2 commits intomainfrom
Conversation
128ef91 to
b38e487
Compare
…anges When a PR has more than 300 changed files, GitHub's diff API returns a too_large error. Instead of failing the workflow, catch this error and fall back to treating all locally changed files as real changes. Made-with: Cursor
b38e487 to
5dd60f9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. |
…slations-too-large
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
mjasikowski
approved these changes
Mar 5, 2026
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
92 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.32-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The
getPullRequestIncrementalChangesGitHub action calls GitHub's pull request diff API duringsynchronizeevents, which has a hard limit of 300 files. When a PR changes more than 300 files, the API returns atoo_largeerror, causing the entiregenerateTranslationsworkflow to fail.This change catches that specific error and ignores it. We will simply ignore translations on such large PRs instead, but this PR should make the workflow pass in such cases.
Fixed Issues
N/A - CI-only fix for an extreme edge case
Tests
None.
Offline tests
None.
QA Steps
None.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
None.