Integrations Error Revamp: Create QuickBooks Desktop integration troubleshooting docs#84205
Integrations Error Revamp: Create QuickBooks Desktop integration troubleshooting docs#84205stephanieelliott wants to merge 1 commit intomainfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| --- | ||
|
|
||
| # How to Fix the DESK03 Error |
There was a problem hiding this comment.
Heading level violation: This uses # (H1) but should use ## (H2). Only the article title should be H1. Section headings like "How to Fix" should be ##. This same issue appears across all new-expensify DESK error files in this PR -- please update them all to use ## How to Fix instead of # How to Fix.
| # How to Fix the DESK03 Error | |
| ## How to Fix the DESK03 Error |
| # How to Fix the DESK08 Error | ||
|
|
||
| Follow the steps below to restore the connection. | ||
|
|
There was a problem hiding this comment.
Heading level violation: # How to Fix should be ## How to Fix. Only the article title (line 8) should use H1. All subsequent section headings must use ## (H2). This pattern is repeated in every new-expensify file in this PR.
| ## How to Fix the DESK08 Error |
| @@ -0,0 +1,6 @@ | |||
| --- | |||
There was a problem hiding this comment.
Incomplete YAML metadata / Placeholder content: This placeholder file is missing required keywords and internalScope fields, has a non-descriptive title ("placeholder file"), and contains unprofessional body content ("hello :)"). Either remove this file from the PR or replace it with a proper article. The same issue applies to all 5 placeholder files in this PR:
Authentication-and-Login-errors/placeholder-file.mdConnection-errors/placeholder-file.mdExport-Errors/placeholder-file.mdSync-Errors/placeholder-file.mdTroubleshooting/placeholder.md
|
|
||
| --- | ||
|
|
||
| # How to Fix the DESK66 Sync Error |
There was a problem hiding this comment.
Heading level violation: # How to Fix should be ## How to Fix. Only the article title should use H1. This applies to all new-expensify Connection-errors files.
| # How to Fix the DESK66 Sync Error | |
| ## How to Fix the DESK66 Sync Error |
|
|
||
| --- | ||
|
|
||
| # How to Fix the DESK88 Export Error |
There was a problem hiding this comment.
Heading level violation: # How to Fix should be ## How to Fix. Only the article title should use H1. This applies to all new-expensify Export-Errors files.
| # How to Fix the DESK88 Export Error | |
| ## How to Fix the DESK88 Export Error |
|
|
||
| --- | ||
|
|
||
| # How to Fix the DESK48 Sync Error |
There was a problem hiding this comment.
Heading level violation: # How to Fix should be ## How to Fix. Only the article title should use H1. This applies to all new-expensify Sync-Errors files.
| # How to Fix the DESK48 Sync Error | |
| ## How to Fix the DESK48 Sync Error |
|
|
||
| ### How to Resolve Automatic Export Errors | ||
|
|
||
| 1. Open the report in Expensify. |
There was a problem hiding this comment.
Heading depth violation: ### How to Resolve Automatic Export Errors uses a level-3 heading (###). HelpDot articles should avoid heading levels deeper than ##. Consider restructuring this as a continuation of the ## section above (plain bold text or a ## heading), rather than nesting to ###. This same pattern applies to lines 43 and 55 in this file, and the equivalent classic FAQ.
|
|
||
| 1. Go to **Settings > Domains**. | ||
| 2. Select your Domain. | ||
| 3. Click **Company Cards**. |
There was a problem hiding this comment.
Expensify Classic navigation in New Expensify article: Settings > Domains is an Expensify Classic navigation path. This article is under the new-expensify/ directory, so the navigation path should reflect New Expensify UI conventions (e.g., Settings > Workspaces > [Workspace name] > Company Cards). Please verify and update the path to match the New Expensify interface.
|
|
||
| ### How to Resolve Export Errors | ||
|
|
||
| 1. Open the report in Expensify. |
There was a problem hiding this comment.
Heading depth violation: ### How to Resolve Export Errors uses a level-3 heading (###). HelpDot articles should avoid heading levels deeper than ##. Consider restructuring this as bold text or a ## heading instead. This same pattern applies to lines 43 and 55 in this file.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aafd39df3c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if git ls-tree --name-only "$SOURCE_BRANCH" -- "$p" 2>/dev/null | head -1 >/dev/null; then | ||
| git checkout "$SOURCE_BRANCH" -- "$p" |
There was a problem hiding this comment.
The guard in this loop does not actually verify that a path exists in SOURCE_BRANCH: git ls-tree returns success even for missing paths, and piping to head keeps the condition truthy. As a result, git checkout "$SOURCE_BRANCH" -- "$p" is still attempted for absent paths and, with set -e, the script aborts mid-run. This breaks the documented workflow whenever one of the listed directories is not present on the source branch (especially likely in the broader “other” batch).
Useful? React with 👍 / 👎.
| title: placeholder | ||
| description: Placeholder file til we get some articles | ||
| --- | ||
|
|
||
| hello :) |
There was a problem hiding this comment.
This article is committed as a normal docs page but contains placeholder-only content (title: placeholder, hello :)). In any docs build/indexing flow that picks up markdown files from this tree, users can encounter this page instead of actionable troubleshooting guidance. Replace it with real content or drop it from the commit to avoid shipping non-functional help docs.
Useful? React with 👍 / 👎.
| @@ -0,0 +1,82 @@ | |||
| --- | |||
| title: DESK03 Error in QuickBooks Desktop Integration | |||
There was a problem hiding this comment.
AI Readiness concern -- duplicate content across categories: This file has identical title, description, keywords, and content as the DESK03-Error.md files in Authentication-and-Login-errors/ and Sync-Errors/. Having the same metadata and content in multiple locations can confuse AI retrieval systems and search indexing. Consider either:
- Differentiating the title/description to reflect the category context (e.g., "DESK03 Export Error in QuickBooks Desktop Integration"), or
- Keeping a single canonical article and redirecting from other locations.
This same duplication pattern affects DESK03, DESK08, DESK23, DESK29, DESK39, DESK74, DESK81, DESK92, and DESK99 across multiple categories in the new-expensify section.
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| title: placeholder | |||
| description: Placeholder file til we get some articles | |||
There was a problem hiding this comment.
Incomplete YAML metadata and unprofessional content: This placeholder file has a generic title ("placeholder"), informal description ("Placeholder file til we get some articles"), is missing keywords and internalScope fields, and contains non-professional body text ("hello :)"). Consider removing placeholder files from the PR entirely if they are not needed for directory structure, or replace with proper stub articles.
| --- | ||
| title: DESK66 Sync Error in QuickBooks Desktop Web Connector | ||
| description: Learn how to fix the DESK66 sync error in QuickBooks Desktop when no data parameter is selected. | ||
| keywords: DESK66, QuickBooks Desktop no data parameter selected, Web Connector sync error, reset QuickBooks permissions certificate, reinstall QBFC driver, reconnect QuickBooks Desktop, Expensify QuickBooks Desktop sync error, Workspace Admin |
There was a problem hiding this comment.
Readability / organizational concern: This file is titled "DESK66 Sync Error" but is placed in the Export-Errors/ folder. The same article also exists in Sync-Errors/ and Connection-errors/. Placing a sync error in the export-errors folder may confuse readers navigating by category. Consider whether this file should only live in Sync-Errors/ and Connection-errors/, or if the title/description should be adjusted to explain its relevance to exports. The same issue applies to Export-Errors/DESK92-Sync-Error.md.
|
|
||
| No data exchange required. | ||
|
|
||
| This behavior is controlled by QuickBooks Web Connector, not the Workspace. |
There was a problem hiding this comment.
Readability: "not the Workspace" is less clear than "not Expensify" (which is used in the equivalent classic article). The cooldown is a QuickBooks Web Connector behavior that is not controlled by Expensify the product, not just "the Workspace." Consider rephrasing.
| This behavior is controlled by QuickBooks Web Connector, not the Workspace. | |
| This behavior is controlled by QuickBooks Web Connector, not Expensify. |
| - More than one QuickBooks Desktop connection exists in the Workspace. | ||
| - Multiple users have attempted to connect QuickBooks Desktop. | ||
| - The system cannot determine which connection should be the preferred exporter. | ||
|
|
There was a problem hiding this comment.
Terminology violation: Use "members" instead of "users" per Expensify style guidelines.
| - Multiple members have attempted to connect QuickBooks Desktop. |
|
|
||
| ## Can Multiple Users Connect QuickBooks Desktop? | ||
|
|
||
| Only one QuickBooks Desktop connection can be designated as the preferred exporter per Workspace. |
There was a problem hiding this comment.
Terminology violation: Use "Members" instead of "Users" per Expensify style guidelines.
| Only one QuickBooks Desktop connection can be designated as the preferred exporter per Workspace. | |
| ## Can Multiple Members Connect QuickBooks Desktop? |
| - The page has not refreshed to reflect recent updates. | ||
| - Multiple users are working in the same Workspace simultaneously. | ||
|
|
||
| When changes overlap, the system requires a refresh to ensure you are working with the latest version. |
There was a problem hiding this comment.
Terminology violation: Use "members" instead of "users" per Expensify style guidelines.
| When changes overlap, the system requires a refresh to ensure you are working with the latest version. | |
| - Multiple members are working in the same Workspace simultaneously. |
HelpDot Documentation Review SummaryPR: #84205 — Integrations Error Revamp: Create QuickBooks Desktop integration troubleshooting docs Overall Scores
Overall: 7.5/10 — Solid foundation with systematic issues that should be addressed before merge. Critical Issues (Must Fix)1. Heading hierarchy violation in ~54 new-expensify files 2. 5 placeholder files should be removed
Moderate Issues (Should Fix)3. Duplicate articles across categories
4. Classic navigation path in new-expensify FAQ 5. Sync-Error files misplaced in Export-Errors folder (classic section) Minor Issues6. Terminology: "users" should be "members" 7. H3 headings in FAQ files Strengths
Recommendations
Generated with Claude Code |
1 participant
Master project issue https://github.com/Expensify/Expensify/issues/469226
Breaking main PR into smaller batches: #83106
Creates .MD files for QuickBooks Desktop integration error messages