Integrations Error Revamp: Create Sage Intacct integration troubleshooting docs#84206
Integrations Error Revamp: Create Sage Intacct integration troubleshooting docs#84206stephanieelliott wants to merge 1 commit intomainfrom
Conversation
HelpDot Documentation ReviewOverall AssessmentThis PR adds 85 new markdown files documenting Sage Intacct integration error codes across both Expensify Classic and New Expensify platforms. The documentation covers authentication, connection, export, and sync errors with a well-structured troubleshooting format. The content is clearly written, actionable, and follows a consistent template. There are a few structural and heading-hierarchy issues that should be addressed before merging. Scores Summary
Key FindingsHeading Hierarchy Inconsistency (Critical)
Duplicate Error Codes Across Multiple Subdirectories Consistent Template Structure (Positive) Strong YAML Metadata (Positive) Error Message Presentation H4 Usage Recommendations
Files Reviewed
This review assessed only the proposed changes (additions) in the PR diff. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47d825b828
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| git fetch origin "$MAIN_BRANCH" 2>/dev/null || true | ||
| git checkout -b "$NEW_BRANCH" "origin/$MAIN_BRANCH" 2>/dev/null || git checkout -b "$NEW_BRANCH" "$MAIN_BRANCH" | ||
| for p in $PATHS; do | ||
| if git ls-tree --name-only "$SOURCE_BRANCH" -- "$p" 2>/dev/null | head -1 >/dev/null; then |
There was a problem hiding this comment.
The existence guard in the loop is ineffective because git ls-tree ... | head -1 >/dev/null returns success even when git ls-tree prints nothing, so the if branch executes for every path. If any configured path is later removed or misspelled in the source branch, git checkout "$SOURCE_BRANCH" -- "$p" will fail under set -e and abort the script before processing remaining paths. This makes the splitter brittle to normal docs tree churn.
Useful? React with 👍 / 👎.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| --- | ||
|
|
||
| # FAQ |
There was a problem hiding this comment.
Heading hierarchy violation: # FAQ is an H1 heading, but each document should have only one H1 (the title). Change this to ## FAQ so it is a second-level heading under the article title.
This same issue (# FAQ instead of ## FAQ) occurs in every file in this PR -- all 82+ instances need to be corrected. Please do a global find-and-replace of # FAQ to ## FAQ across all added files.
|
|
||
| --- | ||
|
|
||
| # How to Fix the INT009 Export Error |
There was a problem hiding this comment.
Heading hierarchy violation: # How to Fix the INT009 Export Error uses an H1 heading. Each document should have exactly one H1 (the title at line 8). Change this to ## How to Fix the INT009 Export Error.
This pattern (# How to Fix ... as H1) appears in all ~39 new-expensify files in this PR. Please do a global find-and-replace of # How to Fix to ## How to Fix across all docs/articles/new-expensify/ files.
|
|
||
| --- | ||
|
|
||
| # FAQ |
There was a problem hiding this comment.
Heading hierarchy violation: # FAQ should be ## FAQ. Only the article title should be H1. This applies to all files in this PR.
| internalScope: Audience is Workspace Admins managing the Sage Intacct integration. Covers resolving the INT245 sync error caused by missing web services user permissions or incomplete reimbursable export configuration. Does not cover export data validation errors. | ||
| --- | ||
|
|
||
| # INT245 Sync Error in Sage Intacct Integration |
There was a problem hiding this comment.
Duplicate content: This file (Connection-errors/INT245-Sync-Error.md) is nearly identical to:
Authentication-and-Login-errors/INT245-Sync-Error.mdSync-Errors/INT245-Sync-Error.md
All three have the same title, same error description, same fix steps, and same FAQ questions. Having three near-identical articles for INT245 across subdirectories will confuse both readers and AI retrieval systems. Consider consolidating into a single canonical article and linking from the other locations, or differentiating the content to cover the error from each category's unique angle.
The same duplication applies to INT907 (3 copies) and INT122 (2 copies in Authentication-and-Login-errors and Sync-Errors).
|
|
||
| If you see the error: | ||
|
|
||
| INT122: Authentication error during sync. |
There was a problem hiding this comment.
Error message formatting: The error text INT122: Authentication error during sync. is displayed as plain text. For better scannability and to visually distinguish the error message from surrounding prose, use a Markdown blockquote:
| INT122: Authentication error during sync. | |
| > INT122: Authentication error during sync. |
This same formatting issue (plain-text error messages after "If you see the error:") applies to virtually all files in this PR. Consider applying blockquote formatting consistently across all error message lines.
|
|
||
| --- | ||
|
|
||
| ## If Exporting as Expense Reports |
There was a problem hiding this comment.
Heading hierarchy issue: ## If Exporting as Expense Reports is at the same heading level (H2) as ## How to Fix the INT245 Sync Error on line 30. Since this section is a sub-step within the "How to Fix" section, it should be demoted to ### If Exporting as Expense Reports.
The same applies to ## If Exporting as Vendor Bills further down (line 68). Both should be H3 sub-sections under the H2 "How to Fix" heading.
This pattern affects the same INT245 and INT009 files in the Connection-errors and Export-Errors directories under expensify-classic.
|
|
||
| --- | ||
|
|
||
| # How to Fix the INT245 Sync Error |
There was a problem hiding this comment.
Heading hierarchy violation: # How to Fix the INT245 Sync Error is an H1 heading. This file already has an H1 title on line 8. Change to ## How to Fix the INT245 Sync Error.
| # How to Fix the INT245 Sync Error | |
| ## How to Fix the INT245 Sync Error |
|
|
||
| --- | ||
|
|
||
| # FAQ |
There was a problem hiding this comment.
Heading hierarchy violation: # FAQ should be ## FAQ.
| # FAQ | |
| ## FAQ |
|
|
||
| If you see the error: | ||
|
|
||
| INT245 Sync Error: Invalid credentials for Sage Intacct. The Sage Intacct user is missing required permissions or the reimbursable export option isn’t fully configured. |
There was a problem hiding this comment.
Error message formatting: The error text is rendered as plain paragraph text. Wrap it in a blockquote for better visual distinction:
| INT245 Sync Error: Invalid credentials for Sage Intacct. The Sage Intacct user is missing required permissions or the reimbursable export option isn’t fully configured. | |
| > INT245 Sync Error: Invalid credentials for Sage Intacct. The Sage Intacct user is missing required permissions or the reimbursable export option isn't fully configured. |
| --- | ||
|
|
||
| # FAQ | ||
|
|
There was a problem hiding this comment.
Heading hierarchy violation: # FAQ should be ## FAQ. Only the article title (line 8) should use H1.
| ## FAQ |
| internalScope: Audience is Workspace Admins using the Sage Intacct integration. Covers resolving the INT907 error caused by invalid or incomplete Sage Intacct connection configuration. Does not cover other Sage Intacct error codes. | ||
| --- | ||
|
|
||
| # INT907 Error in Sage Intacct Integration |
There was a problem hiding this comment.
Duplicate content: This file (Connection-errors/INT907-Error.md) is identical to Authentication-and-Login-errors/INT907-Error.md and Export-Errors/INT907-Error.md in the same expensify-classic tree (and similarly duplicated across new-expensify). The same article appears in 3 subdirectories with the same title, description, and body content.
Consider a single canonical location for each error code article to avoid content drift and confusion for both readers and search/AI systems.
|
|
||
| --- | ||
|
|
||
| # How to Fix the INT245 Sync Error |
There was a problem hiding this comment.
Heading hierarchy violation: # How to Fix the INT245 Sync Error is H1, but the article title on line 8 is already the H1. Change to ## How to Fix the INT245 Sync Error.
| # How to Fix the INT245 Sync Error | |
| ## How to Fix the INT245 Sync Error |
|
|
||
| --- | ||
|
|
||
| # FAQ |
There was a problem hiding this comment.
Heading hierarchy violation: # FAQ should be ## FAQ.
| # FAQ | |
| ## FAQ |
| --- | ||
|
|
||
| # How to Fix the INT907 Error | ||
|
|
There was a problem hiding this comment.
Heading hierarchy violation: # How to Fix the INT907 Error is H1. Change to ## How to Fix the INT907 Error to maintain a single-H1 document structure.
| ## How to Fix the INT907 Error |
|
|
||
| --- | ||
|
|
||
| # FAQ |
There was a problem hiding this comment.
Heading hierarchy violation: # FAQ should be ## FAQ. Only one H1 per document.
| # FAQ | |
| ## FAQ |
|
|
||
| --- | ||
|
|
||
| # FAQ |
There was a problem hiding this comment.
Heading hierarchy violation: # FAQ should be ## FAQ. Each document should have exactly one H1 heading (the title).
| # FAQ | |
| ## FAQ |
|
|
||
| --- | ||
|
|
||
| ## If You Are Not Using Approvals |
There was a problem hiding this comment.
Heading hierarchy issue: ## If You Are Not Using Approvals is at the same heading level (H2) as ## How to Fix the INT009 Export Error (line 34). Since this is a subsection of the fix instructions, it should be ### If You Are Not Using Approvals. The same applies to ## If You Are Using Approvals (line 60).
This pattern of H2 sub-scenarios being siblings of the parent H2 "How to Fix" heading appears in several expensify-classic files including INT009, INT245, INT073, INT084, INT225, and others.
| internalScope: Audience is Workspace Admins using the Sage Intacct integration. Covers resolving the INT122 sync error caused by authentication or Sender ID configuration issues. Does not cover Sage Intacct journal or dimension configuration errors. | ||
| --- | ||
|
|
||
| # INT122 Sync Error in Sage Intacct Integration |
There was a problem hiding this comment.
Duplicate content: This file (Sync-Errors/INT122-Sync-Error.md) covers the same error code and nearly identical content as Authentication-and-Login-errors/INT122-Sync-Error.md in the same expensify-classic tree. Having two copies of the INT122 article in different subdirectories creates maintenance risk and may confuse search indexing. Consider consolidating into a single location.
|
|
||
| --- | ||
|
|
||
| # How to Fix the INT035 Export Error |
There was a problem hiding this comment.
Heading hierarchy violation: # How to Fix the INT035 Export Error is H1, but the document already has an H1 title on line 8. Change to ## How to Fix the INT035 Export Error.
| # How to Fix the INT035 Export Error | |
| ## How to Fix the INT035 Export Error |
| --- | ||
|
|
||
| # How to Fix the INT068 Sync Error | ||
|
|
There was a problem hiding this comment.
Heading hierarchy violation: # How to Fix the INT068 Sync Error is H1. Change to ## How to Fix the INT068 Sync Error to preserve a single-H1 document structure.
| ## How to Fix the INT068 Sync Error |
1 participant
Master project issue https://github.com/Expensify/Expensify/issues/469226
Breaking main PR into smaller batches: #83106
Creates .MD files for Sage Intacct integration error messages