Fix trackExpense to include odometer readings in API params by MelvinBot · Pull Request #84254 · Expensify/App

MelvinBot · 2026-03-05T08:17:18Z

Explanation of Change

The trackExpense function correctly receives odometerStart and odometerEnd from the UI and builds correct optimistic local data with them. However, when constructing the TrackExpenseParams for the TRACK_EXPENSE API call (the default/CREATE case), these fields are omitted entirely. This means the server never receives odometer readings for selfDM tracked expenses, causing the data to be lost after logout/login and the expense to be reclassified as a manual distance expense.

This PR:

Adds odometerStart?: number and odometerEnd?: number to the TrackExpenseParams type
Includes odometerStart and odometerEnd in the API parameters object within the trackExpense default case
Adds isOdometerDistanceRequestTransactionUtils(transaction) to the isDistance flag so the backend correctly identifies odometer expenses as distance requests

This mirrors the existing working pattern in createDistanceRequest / CreateDistanceRequestParams.

Fixed Issues

$ #81728

Tests

Make sure you have the odometerExpenses beta
Create a tracked distance expense using the odometer flow (selfDM)
Verify the expense appears with odometer data
Log out and log back in
Verify the expense still shows odometer data and is classified as a tracked (not manual) distance expense
Verify that no errors appear in the JS console

Verify that no errors appear in the JS console

Offline tests

N/A — requires authentication to persist data to server

QA Steps

Make sure you have the odometerExpenses beta
Create a tracked distance expense using the odometer flow (selfDM)
Verify the expense appears with correct odometer start/end readings
Log out and log back in
Verify the expense still has odometer data and is not reclassified as a manual distance expense
Verify that no errors appear in the JS console

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A — no UI changes, this is a data pass-through fix

Android: mWeb Chrome

N/A — no UI changes

iOS: Native

N/A — no UI changes

iOS: mWeb Safari

N/A — no UI changes

MacOS: Chrome / Safari

N/A — no UI changes

trackExpense receives odometer data from the UI and builds correct optimistic local data, but omits odometerStart and odometerEnd when constructing the API parameters. This means the server never persists odometer readings for selfDM tracked expenses, causing data loss after logout/login and reclassification as manual distance expenses. Also adds isOdometerDistanceRequest to the isDistance flag so the backend correctly identifies odometer expenses as distance requests. Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>

Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>

MelvinBot · 2026-03-05T08:24:55Z

Fixed the Prettier check failure — a long boolean expression in trackExpense needed line wrapping.

The Changed files ESLint check failure is not caused by this PR. It's due to 30 pre-existing @typescript-eslint/no-deprecated violations in src/libs/actions/IOU/index.ts (uses of buildNextStepNew, translateLocal, runAfterInteractions, getPolicyTagsData, getPolicy). These exist identically on main. The new eslint.changed.config.mjs config (introduced today via #83294) escalates @typescript-eslint/no-deprecated from warning to error, which now causes this check to fail for any PR that touches IOU/index.ts. This will need to be addressed separately — either by fixing the deprecation uses or adjusting the lint config.

DylanDylann · 2026-03-05T08:37:51Z

@MelvinBot Ready for review. For failed ESLint, we can add // eslint-disable-next-line @typescript-eslint/no-deprecated above the deprecated usages

The eslint-disable-next-line @typescript-eslint/no-deprecated comments were removed in a recent cleanup (#83798) but only partially restored. This restores the remaining 28 missing directives that are needed for the Changed files ESLint check to pass. Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>

MelvinBot · 2026-03-05T08:41:50Z

Fixed the failing Changed files ESLint check.

Root cause: #83798 removed // eslint-disable-next-line @typescript-eslint/no-deprecated comments from IOU/index.ts as "unused", but these directives are only enforced by the eslint.changed.config.mjs (not the main ESLint config). The follow-up restore commit only restored 3 of the ~30 needed directives, so any PR touching IOU/index.ts would fail this check.

Fix: Restored the 28 missing eslint-disable-next-line @typescript-eslint/no-deprecated comments for pre-existing deprecated API usages (buildNextStepNew, translateLocal, getPolicyTagsData, runAfterInteractions, getPolicy). These are all tracked by existing issues/TODOs in the code.

…U/index.ts Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>

…adings' into claude-fixTrackExpenseOdometerReadings Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>

MelvinBot · 2026-03-05T08:46:22Z

Fixed the failing "Changed files ESLint check" by adding // eslint-disable-next-line @typescript-eslint/no-deprecated above all 30 pre-existing deprecated usages in src/libs/actions/IOU/index.ts. These are not new deprecation issues introduced by this PR — they are existing usages of buildNextStepNew, translateLocal, getPolicyTagsData, runAfterInteractions, and getPolicy that the "Changed files" linter flags because the file was modified.

MelvinBot · 2026-03-05T08:56:21Z

The failing check (Changed files ESLint check) was already fixed in the previous commit (e71c918 — "Fix: Restore missing eslint-disable directives for deprecated API usages"). All checks are now passing, including tests, typecheck, perf-tests, Storybook, ESLint, Prettier, and builds.

DylanDylann · 2026-03-05T08:59:33Z

@MelvinBot Ready for review. I will review this PR

DylanDylann · 2026-03-05T09:12:31Z

@MelvinBot Ready for review

DylanDylann · 2026-03-05T09:15:02Z

@MelvinBot Please mark this PR as ready for review

melvin-bot · 2026-03-05T09:16:24Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-03-05T09:16:25Z

Done — this PR has been marked as ready for review. ✅

DylanDylann · 2026-03-05T09:29:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-03-05.at.16.29.33.mov

DylanDylann · 2026-03-05T09:32:28Z

@Julesssss The code change looks good to me. However, I noticed an issue with the API response. When tracking an expense in a self DM chat with the odometer type, the BE converts it to the manual type in the response.

trjExpensify

bug fix for a WN project 👍

Julesssss

Could you remove the ES lints? I think we should just merge with the failures in this case as there are so many additions

Julesssss · 2026-03-05T18:02:21Z

When tracking an expense in a self DM chat with the odometer type, the BE converts it to the manual type in the response.

I'll get that resolved.

Julesssss · 2026-03-06T00:05:59Z

Backend issue created for the lastDistanceExpenseType being set to manual instead of odometer: https://github.com/Expensify/Expensify/issues/608481

github-actions · 2026-03-06T00:28:14Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-06T00:33:44Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84254.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-ce856d1-f02633f-ff5644b0b753bf1eb7aef8318374a6f40fd2d3ad/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-ce856d1-f02633f-302305426e673931bb11d6b70079fceced0b4b84/index.html

Web 🕸️
https://84254.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-06T04:17:20Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.32-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-06T22:46:31Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned DylanDylann Mar 5, 2026

MelvinBot requested a review from a team March 5, 2026 08:17

MelvinBot mentioned this pull request Mar 5, 2026

[Odometer] Fix trackExpense to persist odometer readings for selfDM tracked expenses #81728

Open

Fix: Prettier formatting for long boolean expression

3a4b11f

Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>

MelvinBot and others added 2 commits March 5, 2026 08:45

Add eslint-disable-next-line for pre-existing deprecated usages in IO…

e25e20d

…U/index.ts Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>

Merge remote-tracking branch 'origin/claude-fixTrackExpenseOdometerRe…

7e6a540

…adings' into claude-fixTrackExpenseOdometerReadings Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>

MelvinBot marked this pull request as ready for review March 5, 2026 09:16

MelvinBot requested a review from a team as a code owner March 5, 2026 09:16

melvin-bot bot requested review from DylanDylann and trjExpensify and removed request for a team March 5, 2026 09:16

melvin-bot bot removed the request for review from a team March 5, 2026 09:16

DylanDylann approved these changes Mar 5, 2026

View reviewed changes

melvin-bot bot requested a review from Julesssss March 5, 2026 09:37

trjExpensify approved these changes Mar 5, 2026

View reviewed changes

Julesssss reviewed Mar 5, 2026

View reviewed changes

Julesssss mentioned this pull request Mar 5, 2026

[Odometer] [Tracking] Add Odometer mileage to NewDot #71841

Open

20 tasks

Julesssss approved these changes Mar 5, 2026

View reviewed changes

Julesssss merged commit ce856d1 into main Mar 5, 2026
33 checks passed

Julesssss deleted the claude-fixTrackExpenseOdometerReadings branch March 5, 2026 23:21

github-actions bot mentioned this pull request Mar 6, 2026

Investigate workflow job failing on main: test / test (job 8) #84341

Closed

OSBotify mentioned this pull request Mar 6, 2026

Deploy Checklist: New Expensify 2026-03-06 #84352

Closed

92 tasks

Conversation

MelvinBot commented Mar 5, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Mar 5, 2026

Uh oh!

DylanDylann commented Mar 5, 2026

Uh oh!

MelvinBot commented Mar 5, 2026

Uh oh!

MelvinBot commented Mar 5, 2026

Uh oh!

MelvinBot commented Mar 5, 2026

Uh oh!

DylanDylann commented Mar 5, 2026

Uh oh!

DylanDylann commented Mar 5, 2026

Uh oh!

DylanDylann commented Mar 5, 2026

Uh oh!

melvin-bot bot commented Mar 5, 2026

Uh oh!

MelvinBot commented Mar 5, 2026

Uh oh!

DylanDylann commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Mar 5, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

Julesssss commented Mar 5, 2026

Uh oh!

Uh oh!

Julesssss commented Mar 6, 2026

Uh oh!

github-actions bot commented Mar 6, 2026

Uh oh!

github-actions bot commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

DylanDylann commented Mar 5, 2026 •

edited

Loading