Closed
Conversation
cuducos
reviewed
Dec 21, 2025
Collaborator
cuducos
left a comment
cuducos
left a comment
There was a problem hiding this comment.
Ao meu ver isso não caracteriza uma minor mas apenas um patch (1.1.1 ao invés de 1.2.0). A maioria dos padrões de versionamentos seguiriam isso, como por exemplo a semântica https://semver.org/
Se você for mudar, seria bom fazer um rebase para evitar um commit com mensagem mencionando versão 1.2.0 quando ainda está na 1.1.1 ; )
| [tool.poetry] | ||
| name = "crossfire" | ||
| version = "1.1.0" | ||
| version = "1.2.0" |
Collaborator
There was a problem hiding this comment.
Suggested change
| version = "1.2.0" | |
| version = "1.1.1" |
Owner
Author
There was a problem hiding this comment.
Thanks. I have checked the semver.org before defining it, but it seems that I overlooked the details. I will apply a rebase and create a new PR with the correct name.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply codestyle to davi PR, and update version to v1.2.0.