fix(etag): rpc and agent etag handling#275
Merged
arnaud-moncel merged 4 commits intomainfrom Mar 4, 2026
Merged
Conversation
1 new issue
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
|
|
||
| def initialize(uri, auth_secret, polling_interval: DEFAULT_POLLING_INTERVAL, introspection_schema: nil, | ||
| introspection_etag: nil, &on_schema_change) | ||
| def initialize(uri, auth_secret, polling_interval: DEFAULT_POLLING_INTERVAL, introspection: nil, |
matthv
reviewed
Mar 3, 2026
packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/schema.rb
Outdated
Show resolved
Hide resolved
matthv
reviewed
Mar 3, 2026
...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb
Outdated
Show resolved
Hide resolved
matthv
reviewed
Mar 3, 2026
| polling_interval: polling_interval, | ||
| introspection_schema: provided_introspection, | ||
| introspection_etag: provided_introspection_etag | ||
| introspection: provided_introspection |
Member
There was a problem hiding this comment.
introspection_schema is still used in
- spec/forest_admin_datasource_rpc_spec.rb
- spec/lib/forest_admin_datasource_rpc/utils/schema_polling_client_spec.rb
matthv
approved these changes
Mar 4, 2026
forest-bot
added a commit
that referenced
this pull request
Mar 4, 2026
## [1.25.1](v1.25.0...v1.25.1) (2026-03-04) ### Bug Fixes * **etag:** rpc and agent etag handling ([#275](#275)) ([c63ad2a](c63ad2a))
Member
|
🎉 This PR is included in version 1.25.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Definition of Done
General
Security