Draft
Conversation
Co-authored-by: sidnarayanan <8095275+sidnarayanan@users.noreply.github.com>
Co-authored-by: sidnarayanan <8095275+sidnarayanan@users.noreply.github.com>
Co-authored-by: sidnarayanan <8095275+sidnarayanan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add finish reason propagation in LLMResult
Store finish_reason in LLMResult
Jan 28, 2026
jamesbraza
reviewed
Jan 28, 2026
| role = None | ||
| reasoning_content = [] | ||
| used_model = None | ||
| choice = None |
Collaborator
There was a problem hiding this comment.
This seems to be an unused local?
Comment on lines
+1112
to
+1114
| finish_reason = ( | ||
| getattr(choice, "finish_reason", None) if choice else None | ||
| ) |
Collaborator
There was a problem hiding this comment.
Don't we know the type here, do we need this getattr?
| ) | ||
| finish_reason: str | None = Field( | ||
| default=None, | ||
| description="The reason the model stopped generating tokens (e.g., 'stop', 'length', 'tool_calls', 'refusal').", |
Collaborator
There was a problem hiding this comment.
Talk about why it would be None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM refusals and other completion states were not propagated, forcing users to rely on
not result.textwhich is unreliable and ambiguous.Changes
finish_reasonfield toLLMResult- optional string capturing completion state (stop,length,tool_calls,refusal, etc.)choice.finish_reasonfrom response and passes to LLMResultfinish_reasonfrom final chunk; also fixed potentialNameErrorif stream is empty by initializingchoice = NoneUsage
Fully backward compatible - field defaults to
None.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
astral.sh/usr/bin/curl curl -LsSf REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
LLMResult#396💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.