Merged
Conversation
eigmax
reviewed
Apr 2, 2026
|
|
||
| fn derive_bip32_root(master_key: &Keypair) -> Xpriv { | ||
| let seed = hkdf_expand(master_key, HKDF_SALT, BITVM_BIP32_ROOT_DOMAIN, 64); | ||
| Xpriv::new_master(Network::Bitcoin, &seed) |
eigmax
reviewed
Apr 2, 2026
| instance_id: Uuid, | ||
| ) -> Result<bitcoin::key::Keypair> { | ||
| let envelope_path = committee_instance_keys_envelope_path(instance_id); | ||
| match committee_master_key.load_instance_keypair(instance_id, &envelope_path) { |
Contributor
There was a problem hiding this comment.
If the envelope exists but is corrupted or has a version mismatch, the function will overwrite it with a new key — losing the old committee identity for that instance. Should distinguish "file not found" from "file corrupt/tampered" and only auto-create on missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create/load/delete) with encrypted disk storage.