Skip to content

Fixes for sanitized dumper#5554

Open
phildominguez-gsa wants to merge 6 commits intomainfrom
pd/fix-sanitized-dumper
Open

Fixes for sanitized dumper#5554
phildominguez-gsa wants to merge 6 commits intomainfrom
pd/fix-sanitized-dumper

Conversation

@phildominguez-gsa
Copy link
Copy Markdown
Contributor

@phildominguez-gsa phildominguez-gsa commented Apr 15, 2026

Related tickets

Description of changes

  • Adding tools back to the Dockerfile that are required for the dumper
  • Replacing accidental keepers variable with correct report_ids_to_delete in remove_tribal_audits.sql
  • Removing DESTINATION input check because it's already hard coded
  • Renaming DATE to TODAY because that's what it is
  • Renaming test_sanitized_production_dump to reload_and_test_sanitized_production_dump because that's what it does
    • Some other improvements here too, basically allowing the user to specify which dump they want to load
  • README tweaks
  • Not addressed in this PR, but we think we discovered a weird timing issue with the backups. In one instance, notes had a report_id that was not yet present in in disseminated_general. Created a ticket here.

How to test

  • Warning: This dumping/loading takes a decent amount of time to complete
  • Follow the quickstart instructions in README-prepare_prod_data_for_local.md to run options 1-5
  • Download the 20260414 dump here and put it in backend/util/load_public_dissem_data/data, then run option 7 to load it
  • Your tables should generally be populated
  • Querying is_public=false on disseminated_general should yield nothing

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

Terraform plan for meta

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

📝 Plan generated in Pull Request Checks #768

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

Terraform plan for dev

Plan: 1 to add, 0 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~      id       = "*******************" -> (known after apply)
!~      triggers = { # forces replacement
!~          "always_run" = "2026-04-17T14:40:02Z" -> (known after apply)
        }
    }

Plan: 1 to add, 0 to change, 1 to destroy.

📝 Plan generated in Pull Request Checks #768

@RanyeM
Copy link
Copy Markdown
Contributor

RanyeM commented Apr 16, 2026

Querying is_public=true on disseminated_general should yield nothing -> my table still shows rows but when is_public=false, it shows nothing

@phildominguez-gsa
Copy link
Copy Markdown
Contributor Author

Querying is_public=true on disseminated_general should yield nothing -> my table still shows rows but when is_public=false, it shows nothing

Oops! I've now fixed that in the instructions. Yes, is_public=false should yield nothing, since those are private/tribal.

@github-actions
Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Branch Rate Health
. 100% 100%
api 98% 86%
api.serializers 97% 88%
api.views 91% 96%
audit 95% 80%
audit.cross_validation 97% 86%
audit.fixtures 84% 50%
audit.formlib 92% 62%
audit.intakelib 89% 83%
audit.intakelib.checks 92% 86%
audit.intakelib.common 98% 82%
audit.intakelib.transforms 100% 95%
audit.management.commands 78% 17%
audit.migrations 100% 100%
audit.models 91% 68%
audit.templatetags 100% 100%
audit.test_viewlib 100% 100%
audit.views 75% 52%
census_historical_migration 96% 65%
census_historical_migration.migrations 100% 100%
census_historical_migration.sac_general_lib 92% 84%
census_historical_migration.transforms 95% 90%
census_historical_migration.workbooklib 68% 69%
config 78% 37%
curation 98% 100%
curation.curationlib 88% 72%
curation.migrations 100% 100%
dissemination 91% 69%
dissemination.analytics 27% 0%
dissemination.forms 80% 30%
dissemination.migrations 97% 25%
dissemination.models 100% 100%
dissemination.report_generation 21% 0%
dissemination.report_generation.excel 32% 0%
dissemination.searchlib 61% 43%
dissemination.templatetags 52% 6%
dissemination.views 67% 47%
djangooidc 53% 38%
djangooidc.tests 100% 94%
report_submission 100% 96%
report_submission.migrations 100% 100%
report_submission.templatetags 74% 100%
report_submission.views 78% 61%
support 94% 75%
support.migrations 100% 100%
support.models 90% 50%
tools 98% 50%
users 95% 86%
users.fixtures 100% 83%
users.management 100% 100%
users.management.commands 100% 100%
users.migrations 100% 100%
Summary 89% (22254 / 25086) 69% (2707 / 3926)

Minimum allowed line rate is 85%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RESUB DE-DUP] A New Data Dump for Local Testing

2 participants