UCUM loading consistent with all other sources#195
Closed
costateixeira wants to merge 5 commits intoHealthIntersections:mainfrom
Closed
UCUM loading consistent with all other sources#195costateixeira wants to merge 5 commits intoHealthIntersections:mainfrom
costateixeira wants to merge 5 commits intoHealthIntersections:mainfrom
Conversation
…rces UCUM was the only terminology source using a path relative to the app root instead of resolving from the terminology-cache folder via getOrDownloadFile. This made config inconsistent — UCUM required `data/terminology-cache/` prefix while LOINC, SNOMED, etc. did not. Now `ucum:ucum-essence-2.2.xml` works the same as `loinc:loinc-2.81-b.db`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy ucum-essence.xml to defaults/data/terminology-cache/ and update test-cases.yml and tx.fhir.org.yml to use the cache-relative path, consistent with the new getOrDownloadFile behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
given that the tx.fhir.org configuration for ucum is |
Contributor
Author
|
https://storage.googleapis.com/tx-fhir-org/ucum-essence.xml does not exist. that is when i spotted this difference in behaviour - all the other cache files work the same except for this. |
Contributor
|
right, it comes from the file in the source code, as it must |
Contributor
Author
|
so the deployment step to other instances should include manually copying it? which one? in storage we have ucum-essence-2.2.xml |
Contributor
|
You don’t need to copy it - it deploys with the code
…On 6 Apr 2026 at 4:16:01 pm, Jose Costa Teixeira ***@***.***> wrote:
*costateixeira* left a comment (HealthIntersections/FHIRsmith#195)
<#195 (comment)>
so the deployment step to other instances should include manually copying
it? which one? in storage we have ucum-essence-2.2.xml
—
Reply to this email directly, view it on GitHub
<#195 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMWKFOVCI67DC2V6UOQ27D4UNDSDAVCNFSM6AAAAACXM2IB6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCOJQGY2DKNBVGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
POSSIBLY BREAKING CHANGE: Existing
ucum:paths in library.yml configs must/should be updated.Old:
ucum:data/terminology-cache/ucum-essence-2.2.xmlNew:
ucum:ucum-essence-2.2.xml(haven't tested, but probably it will just download another copy and it will be ok)
Note
Can amend the PR with a failsafe option
UCUM was the only terminology source using a path relative to the app root instead of resolving from the terminology-cache folder via getOrDownloadFile. This made config inconsistent — UCUM required
data/terminology-cache/prefix while LOINC, SNOMED, etc. did not. Nowucum:ucum-essence-2.2.xmlworks the same asloinc:loinc-2.81-b.db.