UID2-6511 Remove "policy" field from JSON request #69
+15
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swibi-ttd
commented
Feb 9, 2026
uid2_client/token_generate_input.py
Outdated
| # Always use .do_not_generate_tokens_for_opted_out(), which applies policy=1. Support for policy=0 will be removed soon. | ||
| def do_not_generate_tokens_for_opted_out(self): | ||
| self.generate_for_opted_out = False | ||
| # DEPRECATED: The optout_check/policy param has been removed from /token/generate |
Author
There was a problem hiding this comment.
The official @deprecated decorator was only released in 3.13. So this is only "silently" deprecated, unless we wanted to use the external typing-extensions module?
Contributor
There was a problem hiding this comment.
We can use the typing-extensions module. It's better to properly mark this as deprecated!
Author
There was a problem hiding this comment.
Added typing-extensions to dependencies and marked this func as deprecated
sophia-chen-ttd
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do_not_generate_tokens_for_opted_out()as deprecated. The official@warnings.deprecateddecorator is only available in 3.13+"policy"param in JSON body