fix(ai-config): force skills copy read to always use physical FS#1656
Merged
damyanpetev merged 8 commits intomasterfrom Apr 22, 2026
Merged
fix(ai-config): force skills copy read to always use physical FS#1656damyanpetev merged 8 commits intomasterfrom
damyanpetev merged 8 commits intomasterfrom
Conversation
damyanpetev
changed the title
|
coverage: 86.3% (+0.004%) from 86.296% — dpetev/ai-config-fallback-fix into master |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes AI skills template-path fallback so it works when running under Angular schematics’ virtual filesystem (Tree), where absolute on-disk template paths can’t be globbed/read through the virtual IFileSystem.
Changes:
- Convert template
templatePathsskills roots from absolute paths toprocess.cwd()-relative paths inresolveSkillsRoots(). - Update/add unit tests to cover cwd-relative behavior and the “absolute template path → relative skills root” conversion.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/core/util/ai-skills.ts |
Adjusts template fallback skill root computation to use cwd-relative paths. |
spec/unit/ai-skills-spec.ts |
Updates existing template fallback test path setup and adds a new test validating absolute-to-relative conversion for virtual FS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
damyanpetev
changed the title
ChronosSF
previously approved these changes
Apr 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ChronosSF
previously approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Closes #1658
Type of Change
Affected Packages
igniteui-cli(packages/cli)@igniteui/cli-core(packages/core)@igniteui/angular-templates(packages/igx-templates)@igniteui/angular-schematics(packages/ng-schematics)@igniteui/mcp-server(packages/igniteui-mcp)Checklist
npm run test)npm run build)npm run lint)Additional Context