Skip to content

fix(chips): update chip paddings to contain text padding#2190

Merged
simeonoff merged 8 commits intomasterfrom
didimmova/update-chip-paddings
Apr 20, 2026
Merged

fix(chips): update chip paddings to contain text padding#2190
simeonoff merged 8 commits intomasterfrom
didimmova/update-chip-paddings

Conversation

@didimmova
Copy link
Copy Markdown
Contributor

@didimmova didimmova commented Apr 16, 2026

@didimmova didimmova requested a review from simeonoff April 16, 2026 10:48
@didimmova didimmova linked an issue Apr 16, 2026 that may be closed by this pull request
igx-chip has fixed font-size, which makes the content be really tight in smaller chip sizes IgniteUI/igniteui-angular#17115
Closed
kdinev
kdinev reviewed Apr 17, 2026
View reviewed changes
Comment thread src/components/chip/chip.ts
@click=${this._handleSelect}
>
${this._renderPrefix()}
<slot></slot>
Copy link
Copy Markdown
Member

@kdinev kdinev Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a nested <slot> here?

Copy link
Copy Markdown
Contributor Author

@didimmova didimmova Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the slot is not nested, it's just plain text in the DOM and I cannot target the text to place the padding on it.

rkaraivanov
rkaraivanov requested changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@rkaraivanov rkaraivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue:
Since a new content part is introduced, it should be added to the JSDoc of the component @csspart content - <description>, update the relevant section of the specification and the documentation.

Otherwise, the template is fine.

@simeonoff simeonoff requested a review from rkaraivanov April 20, 2026 09:55
@simeonoff
Copy link
Copy Markdown
Collaborator

simeonoff commented Apr 20, 2026

Minor issue: Since a new content part is introduced, it should be added to the JSDoc of the component @csspart content - <description>, update the relevant section of the specification and the documentation.

Otherwise, the template is fine.

Should be fixed now.

@simeonoff simeonoff merged commit c6c264e into master Apr 20, 2026
7 checks passed
@simeonoff simeonoff deleted the didimmova/update-chip-paddings branch April 20, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kdinev kdinev kdinev left review comments

@rkaraivanov rkaraivanov rkaraivanov approved these changes

@simeonoff simeonoff Awaiting requested review from simeonoff

Assignees

@simeonoff simeonoff

@adrianptrv adrianptrv

Labels

chip themes ✅ status: verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

igx-chip has fixed font-size, which makes the content be really tight in smaller chip sizes

5 participants

@didimmova @simeonoff @kdinev @rkaraivanov @adrianptrv