Open
Conversation
nsenave
reviewed
Mar 10, 2026
| : ResponseEntity.ok(NB_DOCS_WITH_FORMATTED | ||
| .formatted(result.dataCount(), result.formattedDataCount(), collectionInstrumentId)); | ||
| } catch (GenesisException e) { | ||
| return ResponseEntity.status(e.getStatus()).body(e.getMessage()); |
There was a problem hiding this comment.
Est-ce qu'on gèrerait pas plutôt via un ExceptionHandler ?
| : ResponseEntity.ok("%d document(s) processed, including %d FORMATTED after data verification" | ||
| .formatted(result.dataCount(), result.formattedDataCount())); | ||
| } catch (GenesisException e) { | ||
| return ResponseEntity.status(e.getStatus()).body(e.getMessage()); |
There was a problem hiding this comment.
ça serait bien de définir des private static final String ... (constante ou fonction) pour faire plaisir à Sonar sur les string dupliquées
| } | ||
|
|
||
| @Override | ||
| public void resetProcessDatesByQuestionnaireId(String questionnaireId) { |
There was a problem hiding this comment.
un commentaire du style // do nothing (stub) pour faire plaisir à sonar ?
|
|
||
| @Override | ||
| public void resetProcessDatesByCollectionInstrumentId(String collectionInstrumentId) { | ||
|
|
| try{ | ||
| return rawData.data().get("validationDate") == null ? null : | ||
| LocalDateTime.parse(rawData.data().get("validationDate").toString()); | ||
| LocalDateTime.parse(rawData.data().get("validationDate").toString(), DateTimeFormatter.ISO_OFFSET_DATE_TIME); |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.