Extend ._tensor_impl with remaining functions used by dpnp#2758
Merged
vlad-perevezentsev merged 41 commits intoinclude-dpctl-tensorfrom Feb 24, 2026
Merged
Extend ._tensor_impl with remaining functions used by dpnp#2758vlad-perevezentsev merged 41 commits intoinclude-dpctl-tensorfrom
._tensor_impl with remaining functions used by dpnp#2758vlad-perevezentsev merged 41 commits intoinclude-dpctl-tensorfrom
Conversation
7 tasks
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.20.0dev3=py313h509198e_49 ran successfully. |
Base automatically changed from
move_tensor_impl_ext
to
include-dpctl-tensor
February 19, 2026 12:19
ndgrigorian
reviewed
Feb 19, 2026
ndgrigorian
reviewed
Feb 19, 2026
dpctl_ext/tensor/libtensor/include/kernels/integer_advanced_indexing.hpp
Show resolved
Hide resolved
ndgrigorian
reviewed
Feb 19, 2026
ndgrigorian
approved these changes
Feb 19, 2026
Collaborator
ndgrigorian
left a comment
There was a problem hiding this comment.
I don't see much else that I would change, looks like you've looked over includes. Only question from my side is the test suite
@antonwolfy if you have any thoughts you should add them but this LGTM
b00d064
into
include-dpctl-tensor
94 of 95 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends
_tensor_implindpctl_ext.tensorwith the remaining functions that are explicitly used indpnpimplementations (_take,_full_usm_ndarray,_zeros_usm_ndarray,_triu) enabling a complete switch todpctl_ext.tensor._tensor_implinstead ofdpctl.tensor._tensor_implIt also adds
take(),put(),full(),tril()andtriu()todpctl_ext.tensorand updates the corresponding dpnp functions to use these implementations internally