Update QR tests to avoid element-wise comparisons#2785
Draft
vlad-perevezentsev wants to merge 5 commits intomasterfrom
Draft
Update QR tests to avoid element-wise comparisons#2785vlad-perevezentsev wants to merge 5 commits intomasterfrom
vlad-perevezentsev wants to merge 5 commits intomasterfrom
Conversation
Contributor
|
Array API standard conformance tests for dpnp=0.20.0dev3=py313h509198e_11 ran successfully. |
Collaborator
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2785/index.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes updating QR tests to avoid direct element-wise comparisons which became unstable with oneMKL 2026.0 due to sign and phase differences in otherwise valid QR results
Since QR factorization is not unique, different MKL and NumPy versions may return results that differ by sign or complex phase while still representing a correct decomposition
To make the tests more stable this PR proposes using invariant-based validation for
mode="raw"andmode="r"based on the unitarity of the Q factor (Q^H Q = I) and the resulting QR identityR^H @ R = A^H @ A