Conversation
There was a problem hiding this comment.
Pull request overview
Prepares the cardano-cli repository for the 10.15.2.0 release by updating dependency pins (CHaP) and bumping the package version/changelog.
Changes:
- Update CHaP revision in
flake.lock. - Bump
cardano-clipackage version to10.15.2.0and add a corresponding changelog header. - Update
cabal.projectCHaP index-state and addactive-repositoriesconfiguration.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| flake.lock | Updates the pinned CHaP input revision/hash for Nix builds. |
| cardano-cli/cardano-cli.cabal | Bumps the package version to 10.15.2.0. |
| cardano-cli/CHANGELOG.md | Adds a 10.15.2.0 section header. |
| cabal.project | Updates CHaP index-state and changes Cabal repository selection behavior via active-repositories. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cardano-cli/CHANGELOG.md
Outdated
| # Changelog for cardano-cli | ||
|
|
||
| ## 10.15.2.0 | ||
|
|
There was a problem hiding this comment.
The new ## 10.15.2.0 section is empty. For a release bump, the changelog should include at least a short bullet describing what changed in this release (e.g., CHaP/index-state update and any user-visible impact), so downstream release notes aren’t blank.
| - Update CHaP index-state and dependencies (maintenance, no user-visible changes) |
cabal.project
Outdated
| -- Custom repository for cardano haskell packages, see CONTRIBUTING for more | ||
| repository cardano-haskell-packages | ||
| -- url: http://localhost:8000/ | ||
| -- secure: False |
There was a problem hiding this comment.
These commented-out settings include an insecure repo configuration (secure: False) and a localhost URL. If this is only for local developer workflows, consider moving it to documentation (or adding an explicit comment explaining it should not be committed/uncommented in release branches) to avoid accidental misuse.
| -- Custom repository for cardano haskell packages, see CONTRIBUTING for more | |
| repository cardano-haskell-packages | |
| -- url: http://localhost:8000/ | |
| -- secure: False | |
| -- Custom repository for cardano haskell packages. | |
| -- For local/developer-only repository setups, see CONTRIBUTING. | |
| -- Do NOT configure a repository here with a localhost URL or `secure: False` | |
| -- in committed or release branches. | |
| repository cardano-haskell-packages |
| active-repositories: | ||
| , :rest | ||
| , cardano-haskell-packages:override |
There was a problem hiding this comment.
Adding active-repositories changes Cabal’s repository selection semantics for all builds. This isn’t mentioned in the PR description and can affect reproducibility/which package versions get picked. Please document the intent (either in the PR description or an inline comment) so it’s clear why :rest + cardano-haskell-packages:override is required for this release.
581dcf0 to
d6e578a
Compare
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist