Skip to content

CHaP update#1357

Merged
coot merged 1 commit intomasterfrom
coot/10.15.2.0
Mar 31, 2026
Merged

CHaP update#1357
coot merged 1 commit intomasterfrom
coot/10.15.2.0

Conversation

@coot
Copy link
Copy Markdown
Contributor

@coot coot commented Mar 30, 2026

Changelog

- description: |
    Updated CHaP
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...
  • Updated CHaP
  • Bump version 10.15.2.0

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@coot coot requested a review from a team as a code owner March 30, 2026 11:46
Copilot AI review requested due to automatic review settings March 30, 2026 11:46
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Prepares the cardano-cli repository for the 10.15.2.0 release by updating dependency pins (CHaP) and bumping the package version/changelog.

Changes:

  • Update CHaP revision in flake.lock.
  • Bump cardano-cli package version to 10.15.2.0 and add a corresponding changelog header.
  • Update cabal.project CHaP index-state and add active-repositories configuration.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File Description
flake.lock Updates the pinned CHaP input revision/hash for Nix builds.
cardano-cli/cardano-cli.cabal Bumps the package version to 10.15.2.0.
cardano-cli/CHANGELOG.md Adds a 10.15.2.0 section header.
cabal.project Updates CHaP index-state and changes Cabal repository selection behavior via active-repositories.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# Changelog for cardano-cli

## 10.15.2.0

Copy link

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new ## 10.15.2.0 section is empty. For a release bump, the changelog should include at least a short bullet describing what changed in this release (e.g., CHaP/index-state update and any user-visible impact), so downstream release notes aren’t blank.

Suggested change
- Update CHaP index-state and dependencies (maintenance, no user-visible changes)

Copilot uses AI. Check for mistakes.
cabal.project Outdated
Comment on lines +1 to +4
-- Custom repository for cardano haskell packages, see CONTRIBUTING for more
repository cardano-haskell-packages
-- url: http://localhost:8000/
-- secure: False
Copy link

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These commented-out settings include an insecure repo configuration (secure: False) and a localhost URL. If this is only for local developer workflows, consider moving it to documentation (or adding an explicit comment explaining it should not be committed/uncommented in release branches) to avoid accidental misuse.

Suggested change
-- Custom repository for cardano haskell packages, see CONTRIBUTING for more
repository cardano-haskell-packages
-- url: http://localhost:8000/
-- secure: False
-- Custom repository for cardano haskell packages.
-- For local/developer-only repository setups, see CONTRIBUTING.
-- Do NOT configure a repository here with a localhost URL or `secure: False`
-- in committed or release branches.
repository cardano-haskell-packages

Copilot uses AI. Check for mistakes.
Comment on lines +21 to +23
active-repositories:
, :rest
, cardano-haskell-packages:override
Copy link

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding active-repositories changes Cabal’s repository selection semantics for all builds. This isn’t mentioned in the PR description and can affect reproducibility/which package versions get picked. Please document the intent (either in the PR description or an inline comment) so it’s clear why :rest + cardano-haskell-packages:override is required for this release.

Copilot uses AI. Check for mistakes.
carbolymer

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split this into two PRs? one updating chap, and the other making a release?

@coot coot force-pushed the coot/10.15.2.0 branch 2 times, most recently from 581dcf0 to d6e578a Compare March 30, 2026 12:16
Copy link
Copy Markdown
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment in the project file explaining what this change does and why this change is necessary?

@Jimbo4350 Jimbo4350 self-requested a review March 30, 2026 14:53
@coot coot dismissed carbolymer’s stale review March 30, 2026 15:54

Review comment was addressed.

@coot coot enabled auto-merge March 30, 2026 15:54
@coot coot changed the title 10.15.2.0 CHaP update Mar 30, 2026
@coot coot added this pull request to the merge queue Mar 30, 2026
github-merge-queue bot pushed a commit that referenced this pull request Mar 30, 2026
@coot coot self-assigned this Mar 30, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 30, 2026
@coot coot added this pull request to the merge queue Mar 30, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 30, 2026
@coot coot added this pull request to the merge queue Mar 31, 2026
Merged via the queue into master with commit d622c30 Mar 31, 2026
33 of 35 checks passed
@coot coot deleted the coot/10.15.2.0 branch March 31, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants