Let IronPython Compiler only create one exe file when target to exe or winexe#1786
Open
wherewhere wants to merge 11 commits intoIronLanguages:mainfrom
Open
Let IronPython Compiler only create one exe file when target to exe or winexe#1786wherewhere wants to merge 11 commits intoIronLanguages:mainfrom
wherewhere wants to merge 11 commits intoIronLanguages:mainfrom
Conversation
Have not add Win32 Icon since AssemblyBuilder dose not have DefineIconResource method
Author
Author
|
The Win32 icon setting is working now. |
since .NET Core App does not have it
Author
|
I am confused about why the host should have to try catch. The error would show when they are occurred. public static class PythonMain
{
public static int Main()
{
try
{
return PythonOps.InitializeModuleEx(typeof(PythonMain).Assembly, "__main__", null, ignoreEnvVars: false, null);
}
catch (Exception ex)
{
string message = ex.Message;
Console.WriteLine("Error occurred: {0}", message);
return -1;
}
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The issue is #1785
I add a new method
CreateAssemblyGeninClrModuleto getAssemblyGen, so that I can add exe host code into ScriptCode assembly. Then I change the init code fromto
since the ScriptCode assembly is itself.
But now it have some new problem. Since the
AssemblyBuilderdose not haveDefineIconResourcemethod, I have no ideal to add win32 icon. And the Windows Defender said it is viruses when/standaloneoption is on...PS. I use reflection to invoke
SavableScriptCode.CompileForSavesinceSavableScriptCodeis inDLRrepository. It is better to addCreateAssemblyGenmethod forSavableScriptCode.