feat(zcash): add deviceVersion to ZcashAccounts#39
Open
czarcas7ic wants to merge 1 commit intoKeystoneHQ:masterfrom
Open
feat(zcash): add deviceVersion to ZcashAccounts#39czarcas7ic wants to merge 1 commit intoKeystoneHQ:masterfrom
czarcas7ic wants to merge 1 commit intoKeystoneHQ:masterfrom
Conversation
Add optional deviceVersion field to the Swift ZcashAccounts model. Parsed from the CBOR encoding when present, nil for old firmware that doesn't include it. Backwards compatible via Codable optionals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes KeystoneHQ/keystone3-firmware#2147
Summary
deviceVersion: String?to the SwiftZcashAccountsmodelCodabletreats absent JSON fields asnilBefore merge
Update
Package.swiftbinaryTarget URL and checksum to point to the newURRegistryFFI.xcframework.ziprelease created after KeystoneHQ/keystone-sdk-rust#127 merges. The current checksum referencessdk-0.2.3which doesn't havedevice_versionin the FFI layer.Depends on
Testing
Using all three device version PRs I have opened
KeystoneHQ/keystone-sdk-rust#127
#39
KeystoneHQ/keystone3-firmware#2138
I tested against a zodl app that prints a debug line when connecting the keystone. We see that the keystone version is correctly communicated when connecting the hardware wallet:
debug-show-version-when-connected.mp4
Docs
I wrote up a short doc on how we will use QR pairing and data added when responding with the signed PCZT in order to achieve version negotiation for the upcoming quantum recoverability feature in zcash
https://hackmd.io/@valargroup/H1pGeaFh-l