replace unicode escape characters with readable unicode characters#224
Open
Elyahu41 wants to merge 2 commits intoKosherJava:masterfrom
Open
replace unicode escape characters with readable unicode characters#224Elyahu41 wants to merge 2 commits intoKosherJava:masterfrom
Elyahu41 wants to merge 2 commits intoKosherJava:masterfrom
Conversation
Contributor
Author
|
@KosherJava I just noticed the the parsha "וזאת הברכה " has an extra space in the string. See line 253 in the HebrewDateFormatter class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is not needed right now, but it seems like IntelliJ says that the Unicode escape characters can be replaced with other characters. I do not believe this will break anything, and it will be much easier to read the code this way.
I will leave this PR here for testing reasons, and if you ever want to convert the strings, the work is done for you!