add method checking for a shmita year#225
Open
Elyahu41 wants to merge 2 commits intoKosherJava:masterfrom
Open
add method checking for a shmita year#225Elyahu41 wants to merge 2 commits intoKosherJava:masterfrom
Elyahu41 wants to merge 2 commits intoKosherJava:masterfrom
Conversation
|
It just looks like a clone of isIsruChag() |
Contributor
Author
|
@NightScript370 you are right! Oops, I guess I forgot to actually write the code in the method. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am surprised that this method is not already in the JewishCalendar class. It was the first method that I was looking for when I first started looking at the documentation. I believe that it is a good addition.