Conversation
…rt, add .env.example, update README Agent-Logs-Url: https://github.com/LCAS/MDPCalib/sessions/780fdaf0-353c-492b-ad82-dee7b0de0d96 Co-authored-by: marc-hanheide <1153084+marc-hanheide@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add GitHub workflow to build container and push to registry
Add GitHub Actions workflow to build and push Docker image; update docker-compose for standalone use
Apr 27, 2026
marc-hanheide
requested review from
cooperj
and removed request for
marc-hanheide
cooperj
reviewed
Apr 27, 2026
| env: | ||
| REGISTRY: ghcr.io | ||
| # github.repository is 'LCAS/MDPCalib'; ghcr.io automatically lowercases | ||
| # the path, so the published image is ghcr.io/lcas/mdpcalib. |
Member
There was a problem hiding this comment.
Is the correct way that we want to do this instead of hosting on lcas.lincoln.ac.uk
| environment: | ||
| - DISPLAY | ||
| - XAUTHORITY | ||
| - DISPLAY=${DISPLAY:-:0} |
Member
There was a problem hiding this comment.
Do we want to instead configure lcas.lincoln.ac.uk/vnc so that you arent relying on having access to /tmp/.X11-unix (i.e. for a remote machine)
| cp .env.example .env | ||
| # Edit .env (not .env.example) and set DATA_PATH to your local data directory | ||
| ``` | ||
| 3. Allow GUI applications (e.g. RViz) to connect to your display: |
Member
There was a problem hiding this comment.
As previous, if we use the vnc container we dont need to do this.
| # Docker image to use. | ||
| # Use a specific version tag for reproducible deployments, e.g.: | ||
| # MDPCALIB_IMAGE=ghcr.io/lcas/mdpcalib:v1.0.0 | ||
| MDPCALIB_IMAGE=ghcr.io/lcas/mdpcalib:latest |
Member
There was a problem hiding this comment.
Is this needed to be ran here, instead can we hard code in the compose file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users need a way to run MDPCalib without checking out the full source — just
docker-compose.yaml+ a local.envfile should be sufficient. The container image should be built and published automatically on every push tomainand on version tags.Changes
.github/workflows/docker-build-push.ymlpushtomain,v*tags, andworkflow_dispatchghcr.iowith the built-inGITHUB_TOKEN(no extra secrets)ghcr.io/lcas/mdpcalib:latestfrommain; semver tags (1.2.3,1.2) from version tagstype=gha) to speed up rebuildsdocker-compose.yamlbuild: context: .toimage: ${MDPCALIB_IMAGE:-ghcr.io/lcas/mdpcalib:latest}.env:.env.example.envREADME.mddocker-compose.yaml+.env.example, edit.env,docker compose run) that requires no source checkoutdocker-compose.override.ymlto build from source with./srcmounted.gitignore.envso local environment files are never accidentally committed