GitHub Issue 867: Cannot filter through a file data field#7452
Merged
GitHub Issue 867: Cannot filter through a file data field#7452
Conversation
|
|
||
| this.allowFacet = false; | ||
| if (this.column.inputType === 'file') | ||
| return this.allowFacet; |
Contributor
There was a problem hiding this comment.
It looks like this.column.facetingBehaviorType has the default value of AUTOMATIC. Is there no good way to set it to ALWAYS_OFF? Then we wouldn't have to special case this. Looks like MutableColumnInfoWrapper has a setter method.
Contributor
Author
There was a problem hiding this comment.
Good point. I'll look into this approach instead.
Contributor
Author
There was a problem hiding this comment.
Switched to columnInfo approach.
labkey-susanh
approved these changes
Feb 25, 2026
labkey-susanh
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Enable sort/filter for file columns, but don't allow faceted filtering for those columns.
Related Pull Requests
Changes