Skip to content

GitHub Issue 867: Cannot filter through a file data field#7452

Merged
XingY merged 7 commits intodevelopfrom
fb_fileFilter
Feb 27, 2026
Merged

GitHub Issue 867: Cannot filter through a file data field#7452
XingY merged 7 commits intodevelopfrom
fb_fileFilter

Conversation

@XingY
Copy link
Contributor

@XingY XingY commented Feb 25, 2026

Rationale

Enable sort/filter for file columns, but don't allow faceted filtering for those columns.

Related Pull Requests

Changes


this.allowFacet = false;
if (this.column.inputType === 'file')
return this.allowFacet;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this.column.facetingBehaviorType has the default value of AUTOMATIC. Is there no good way to set it to ALWAYS_OFF? Then we wouldn't have to special case this. Looks like MutableColumnInfoWrapper has a setter method.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I'll look into this approach instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched to columnInfo approach.

@XingY XingY requested a review from labkey-susanh February 25, 2026 23:15
@XingY XingY merged commit 15032b2 into develop Feb 27, 2026
10 checks passed
@XingY XingY deleted the fb_fileFilter branch February 27, 2026 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants