Fix STT-only model selection in darkbloom start#52
Open
cryptosingheth wants to merge 1 commit intoLayr-Labs:masterfrom
Open
Fix STT-only model selection in darkbloom start#52cryptosingheth wants to merge 1 commit intoLayr-Labs:masterfrom
cryptosingheth wants to merge 1 commit intoLayr-Labs:masterfrom
Conversation
|
@cryptosingheth is attempting to deploy a commit to the EigenLabs Team on Vercel. A member of the Team first needs to authorize it. |
906d9e8 to
6c1afe8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #42 for the
No models selectedloop when selecting onlyCohere Transcribe [transcription].The issue was reproduced on a Mac Mini, but the root cause is not Mac Mini-specific.
hardware::detect()only controls which catalog entries fit the machine's RAM; the failure happens later in generic startup selection validation after the picker has already returned selected entries. Any Mac provider that selects only an STT/transcription model can hit the same error.The separate
ModuleNotFoundError: No module named 'mlx_audio.stt.cohere_asr'symptom mentioned in #42 is a runtime/package issue and is not covered by this PR.Root Cause
cmd_startalready split selected picker entries into:--model--image-modelEIGENINFERENCE_STT_MODELHowever, the final validation only checked text and image selections:
So
picked_sttcould be populated correctly, but STT-only startup still failed before launchd service installation.Changes
has_start_selectionhelper that treats text, image, and STT selections as valid startup workloads.darkbloom startguard to includepicked_stt.master; while validating that base, also applies formatter-only cleanup incrypto.rs/secure_enclave_key.rsand gates the in-process engine scratch variable behind the existingpythonfeature so--no-default-featurescompiles.Validation
cd provider && cargo fmt --checkcd provider && cargo test --no-default-featuresNote: an initial sandboxed test run failed because local mock-server socket binding was denied with
Operation not permitted; the same test command passed when rerun outside the sandbox.