Fixes and improvements to the ltfs_ordered_copy tool#586
Open
asivery wants to merge 2 commits intoLinearTapeFileSystem:mainfrom
Open
Fixes and improvements to the ltfs_ordered_copy tool#586asivery wants to merge 2 commits intoLinearTapeFileSystem:mainfrom
asivery wants to merge 2 commits intoLinearTapeFileSystem:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This pull request includes following changes or fixes:
ltfs_ordered_copytool crashing due to comparingbyteswithstr.Description
The first fix was required for me to even use this tool under modern python and
pyxattr.I believe a better progress bar might be more useful when copying smaller amounts of larger files - as of right now, this utility only shows the number of the file that's being copied.
I also believe it might be worth documenting somewhere, that sometimes it's absolutely crucial to use this tool instead of the system-avaliable
cporrsync. Without it, my drive (SAS IBM LTO7-HH) kept thrashing and throwing IO errors. Also, since python2 reached EOL six years ago, I think it might be worth removing mentions of it from the README.Type of change
Checklist: