Remove duplicate R3bar accumulation line that doubles bubble perturbation#1183
Remove duplicate R3bar accumulation line that doubles bubble perturbation#1183sbryngelson wants to merge 1 commit intoMFlowCode:masterfrom
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
CodeAnt AI finished reviewing your PR. |
There was a problem hiding this comment.
Pull request overview
Removes a character-for-character duplicate accumulation statement that caused R3bar to be double-counted in QBMM bubble perturbation calculations.
Changes:
- Delete the duplicated
R3baraccumulation line inside theqbmmloop to prevent doubling the computed moment.
…tion Character-for-character identical duplicate line causes R3bar to always be 2x the intended value for QBMM cases. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
826dd03 to
febe506
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1183 +/- ##
=======================================
Coverage 44.05% 44.05%
=======================================
Files 70 70
Lines 20498 20497 -1
Branches 1990 1991 +1
=======================================
Hits 9030 9030
+ Misses 10329 10328 -1
Partials 1139 1139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Severity: HIGH — doubles bubble perturbation for QBMM cases.
File:
src/pre_process/m_assign_variables.fpp, lines 235-236Character-for-character identical duplicate line in the QBMM branch of the R3bar accumulation loop. This doubles the computed value of R3bar.
Before
After
Why this went undetected
QBMM is a specialized bubble dynamics feature. The doubled R3bar produces a systematically wrong (but not obviously broken) bubble volume fraction initialization.
Test plan
🤖 Generated with Claude Code
Fixes #1203