Skip to content

Comments

Remove debug print left in post-process production code#1185

Open
sbryngelson wants to merge 1 commit intoMFlowCode:masterfrom
sbryngelson:fix/remove-debug-print
Open

Remove debug print left in post-process production code#1185
sbryngelson wants to merge 1 commit intoMFlowCode:masterfrom
sbryngelson:fix/remove-debug-print

Conversation

@sbryngelson
Copy link
Member

@sbryngelson sbryngelson commented Feb 21, 2026

Summary

Severity: HIGH — spams stdout with variable data during every post-process run.

File: src/post_process/m_data_input.f90, line 315

A debug print * statement was left in production code. It prints the entire conservative variable slice q_cons_vf(i)%sf(:, 0, 0) to stdout for every variable at every timestep during serial post-processing.

Before

read (1) q_cons_vf(i)%sf(0:m, 0:n, 0:p)
close (1)
print *, q_cons_vf(i)%sf(:, 0, 0)    ! debug print left in

After

read (1) q_cons_vf(i)%sf(0:m, 0:n, 0:p)
close (1)

Test plan

  • Run post-processing and verify no spurious stdout output

🤖 Generated with Claude Code

Fixes #1205

Copilot AI review requested due to automatic review settings February 21, 2026 03:23
@codeant-ai
Copy link
Contributor

codeant-ai bot commented Feb 21, 2026

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 21, 2026

Warning

Rate limit exceeded

@sbryngelson has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 28 minutes and 24 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codeant-ai
Copy link
Contributor

codeant-ai bot commented Feb 21, 2026

CodeAnt AI finished reviewing your PR.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a debug print statement that was inadvertently left in the post-processing production code, which was causing spurious output to stdout for every conservative variable at every timestep.

Changes:

  • Removed debug print statement from post-processing data input routine

cubic-dev-ai[bot]

This comment was marked as off-topic.

Prints conservative variable slices to stdout for every variable
at every timestep during post-processing.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.05%. Comparing base (84c46e0) to head (f12479c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1185   +/-   ##
=======================================
  Coverage   44.05%   44.05%           
=======================================
  Files          70       70           
  Lines       20498    20497    -1     
  Branches     1990     1990           
=======================================
  Hits         9030     9030           
+ Misses      10329    10328    -1     
  Partials     1139     1139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

loc_violations used uninitialized in MPI_Allreduce

1 participant