Remove debug print left in post-process production code#1185
Remove debug print left in post-process production code#1185sbryngelson wants to merge 1 commit intoMFlowCode:masterfrom
Conversation
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
CodeAnt AI finished reviewing your PR. |
There was a problem hiding this comment.
Pull request overview
This PR removes a debug print statement that was inadvertently left in the post-processing production code, which was causing spurious output to stdout for every conservative variable at every timestep.
Changes:
- Removed debug print statement from post-processing data input routine
Prints conservative variable slices to stdout for every variable at every timestep during post-processing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
8097d9b to
f12479c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1185 +/- ##
=======================================
Coverage 44.05% 44.05%
=======================================
Files 70 70
Lines 20498 20497 -1
Branches 1990 1990
=======================================
Hits 9030 9030
+ Misses 10329 10328 -1
Partials 1139 1139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Severity: HIGH — spams stdout with variable data during every post-process run.
File:
src/post_process/m_data_input.f90, line 315A debug
print *statement was left in production code. It prints the entire conservative variable sliceq_cons_vf(i)%sf(:, 0, 0)to stdout for every variable at every timestep during serial post-processing.Before
After
Test plan
🤖 Generated with Claude Code
Fixes #1205