Skip to content

Muesli: PR 11.1 - Performance policy#1069

Open
fosterfarrell9 wants to merge 9 commits intomuesli/certificationsfrom
muesli/performance-policy
Open

Muesli: PR 11.1 - Performance policy#1069
fosterfarrell9 wants to merge 9 commits intomuesli/certificationsfrom
muesli/performance-policy

Conversation

@fosterfarrell9
Copy link
Copy Markdown
Collaborator

@fosterfarrell9 fosterfarrell9 commented Mar 5, 2026

This PR provides the backend foundation for student performance policies for campaigns.

@fosterfarrell9 fosterfarrell9 requested a review from Splines as a code owner March 5, 2026 14:26
@fosterfarrell9 fosterfarrell9 requested a review from Copilot March 5, 2026 14:27
@fosterfarrell9 fosterfarrell9 changed the title Muesli: PR 12.1 - Performance policy Muesli: PR 11.1 - Performance policy Mar 5, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds backend support for a new student_performance registration policy kind, including validation, evaluation, and UI wiring, to serve as the foundation for campaign performance gating.

Changes:

  • Introduces Registration::Policy::StudentPerformanceHandler and wires it into Registration::Policy#handler.
  • Extends policy form handling/strong params to support selecting a lecture for the policy.
  • Adds specs and i18n strings for validating and evaluating the new policy behavior.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
spec/models/registration/policy_spec.rb Adds model validation specs for student_performance config/lecture existence.
spec/models/registration/policy_engine_spec.rb Adds eligibility evaluation coverage for student_performance policies across phases.
spec/models/registration/policy/student_performance_handler_spec.rb New unit specs for handler evaluate/validate/summary behavior.
spec/factories/registration_policies.rb Ensures :student_performance trait auto-populates lecture_id in config.
config/locales/registration/en.yml Adds validation error strings for lecture selection.
config/locales/registration/de.yml Adds validation error strings for lecture selection.
app/models/registration/policy/student_performance_handler.rb Implements evaluation/validation/summary for the new policy kind.
app/models/registration/policy.rb Adds lecture_id virtual accessor and routes :student_performance to the new handler.
app/frontend/registration/policies/_form.html.erb Updates the policy form to use lecture_id virtual attribute (collection_select).
app/controllers/registration/policies_controller.rb Permits lecture_id in strong params.

Comment thread app/models/registration/policy/student_performance_handler.rb Outdated
Comment thread app/models/registration/policy/student_performance_handler.rb Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants