Muesli: PR 11.1 - Performance policy#1069
Open
fosterfarrell9 wants to merge 9 commits intomuesli/certificationsfrom
Open
Muesli: PR 11.1 - Performance policy#1069fosterfarrell9 wants to merge 9 commits intomuesli/certificationsfrom
fosterfarrell9 wants to merge 9 commits intomuesli/certificationsfrom
Conversation
…inalization phase
… section with lecture selection
Contributor
There was a problem hiding this comment.
Pull request overview
Adds backend support for a new student_performance registration policy kind, including validation, evaluation, and UI wiring, to serve as the foundation for campaign performance gating.
Changes:
- Introduces
Registration::Policy::StudentPerformanceHandlerand wires it intoRegistration::Policy#handler. - Extends policy form handling/strong params to support selecting a lecture for the policy.
- Adds specs and i18n strings for validating and evaluating the new policy behavior.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/models/registration/policy_spec.rb | Adds model validation specs for student_performance config/lecture existence. |
| spec/models/registration/policy_engine_spec.rb | Adds eligibility evaluation coverage for student_performance policies across phases. |
| spec/models/registration/policy/student_performance_handler_spec.rb | New unit specs for handler evaluate/validate/summary behavior. |
| spec/factories/registration_policies.rb | Ensures :student_performance trait auto-populates lecture_id in config. |
| config/locales/registration/en.yml | Adds validation error strings for lecture selection. |
| config/locales/registration/de.yml | Adds validation error strings for lecture selection. |
| app/models/registration/policy/student_performance_handler.rb | Implements evaluation/validation/summary for the new policy kind. |
| app/models/registration/policy.rb | Adds lecture_id virtual accessor and routes :student_performance to the new handler. |
| app/frontend/registration/policies/_form.html.erb | Updates the policy form to use lecture_id virtual attribute (collection_select). |
| app/controllers/registration/policies_controller.rb | Permits lecture_id in strong params. |
…_id before lecture existence
…HD/mampf into muesli/performance-policy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides the backend foundation for student performance policies for campaigns.