Add test_files content to packaging#27
Open
dhgutteridge wants to merge 2 commits intoMartijnBraam:masterfrom
Open
Add test_files content to packaging#27dhgutteridge wants to merge 2 commits intoMartijnBraam:masterfrom
dhgutteridge wants to merge 2 commits intoMartijnBraam:masterfrom
Conversation
Provide test_files content in the distribution so downstream packagers sourcing from PyPI can run all tests successfully. While here, also note Python 3.6 support, since that's what I'm using it with.
Author
|
While packaging this for pkgsrc.org, which prefers sourcing distribution files via PyPI, I found the distribution file doesn't include the test_files directory, so six of the sixteen tests fail. It's preferable to include all test files for optional inclusion downstream. |
Author
|
One of the Travis CI jobs failed, but apparently not for reasons relating to this change. It looks like a fundamental problem with Python 3.3 coverage: "RuntimeError: Python 3.4 or later is required." |
tgandor
reviewed
May 12, 2019
| 'Programming Language :: Python :: 3.4', | ||
| 'Programming Language :: Python :: 3.5' | ||
| 'Programming Language :: Python :: 3.5', | ||
| 'Programming Language :: Python :: 3.6' |
There was a problem hiding this comment.
Trailing comma? -> cleaner diffs down the road
Author
There was a problem hiding this comment.
Sure, I could add that. (I just noted it works with 3.7 as well.) I hadn't done that because it didn't seem to be the original author's style.
The test suite passes on Python 3.7, and I've been using it with 3.7 successfully for months.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide test_files content in the distribution so downstream packagers sourcing from PyPI can run all tests successfully. While here, also note Python 3.6 support, since that's what I'm using it with.