Skip to content

Foreign key child feature fix#4356

Open
gabriel-bolbotina wants to merge 3 commits intomasterfrom
fix/1-to-n-foreign-key
Open

Foreign key child feature fix#4356
gabriel-bolbotina wants to merge 3 commits intomasterfrom
fix/1-to-n-foreign-key

Conversation

@gabriel-bolbotina
Copy link
Contributor

@gabriel-bolbotina gabriel-bolbotina commented Feb 27, 2026

Modified logic in attribute controller as such:

  • if the child feature form has the foreign key field visible, keep the code as it was
  • if the field is not visible, search for the field in the child layer (not only in the visible form fields), and pre-fill the relation

@github-actions
Copy link

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 64291 dmg Expires: 28/05/2026 #6429
linux Build 📭 Build not yet complete or failed.
win64 Build 📬 Mergin Maps 56242 win64 Expires: 28/05/2026 #5624
Android Build 📬 Mergin Maps 773951 APK [arm64-v8a] Expires: 28/05/2026 #7739
Android Build 📬 Mergin Maps 773911 APK [armeabi-v7a] Expires: 28/05/2026 #7739
iOS Build 📬 Build number: 26.02.868011 #8680

@gabriel-bolbotina gabriel-bolbotina changed the title Initial draft Foreign key child feature fix Mar 2, 2026
@Withalion Withalion added the FROZEN 🥶 do not merge before upcoming release label Mar 2, 2026
@github-actions
Copy link

github-actions bot commented Mar 2, 2026

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 64331 dmg Expires: 31/05/2026 #6433
linux Build 📬 Mergin Maps 64441 x86_64 Expires: 31/05/2026 #6444
win64 Build 📬 Mergin Maps 56281 win64 Expires: 31/05/2026 #5628
Android Build 📬 Mergin Maps 774351 APK [arm64-v8a] Expires: 31/05/2026 #7743
Android Build 📬 Mergin Maps 774311 APK [armeabi-v7a] Expires: 31/05/2026 #7743
iOS Build 📬 Build number: 26.03.868411 #8684

@gabriel-bolbotina gabriel-bolbotina marked this pull request as ready for review March 2, 2026 09:37
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 64521 dmg Expires: 01/06/2026 #6452
linux Build 📭 Build not yet complete or failed.
win64 Build 📬 Mergin Maps 56471 win64 Expires: 01/06/2026 #5647
Android Build 📭 Build not yet complete or failed.
iOS Build 📬 Build number: 26.03.870311 #8703

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 64541 dmg Expires: 01/06/2026 #6454
linux Build 📭 Build not yet complete or failed.
win64 Build 📬 Mergin Maps 56491 win64 Expires: 01/06/2026 #5649
Android Build 📬 Mergin Maps 776411 APK [armeabi-v7a] Expires: 01/06/2026 #7764
Android Build 📬 Mergin Maps 776451 APK [arm64-v8a] Expires: 01/06/2026 #7764
iOS Build 📬 Build number: 26.03.870511 #8705

Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good! :) We agreed to revert the CI-related (cppcheck) changes

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📭 Build not yet complete or failed.
linux Build 📬 Mergin Maps 64841 x86_64 Expires: 03/06/2026 #6484
win64 Build 📬 Mergin Maps 56681 win64 Expires: 03/06/2026 #5668
Android Build 📬 Mergin Maps 778311 APK [armeabi-v7a] Expires: 03/06/2026 #7783
Android Build 📬 Mergin Maps 778351 APK [arm64-v8a] Expires: 03/06/2026 #7783
iOS Build 📬 Build number: 26.03.872411 #8724

@Withalion Withalion removed the FROZEN 🥶 do not merge before upcoming release label Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants