You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reason: When the user opens the new tab on a non-legacy page, the redux store data is not initialized. So when the user goes to logout (from the header) the logout action clears nothing because the store isn't initialized
Fix: Initialize the redux store data from all pages without waiting on it to finish hydrating. The non-legacy pages will initialize the store data but it wont be ready until the client rehydrates it (potential bug - but low odds of it happening).
Also added some small fixes for best practices (image) and lighthouse url fix
Expected behavior:
User logs in -> user closes the browser tab -> user opens a new tab (any page) -> user goes to logout -> user is able to log back in
Testing tips:
Attempt the expected behaviour
Future
With SSR (stateless by design) handling Redux state feels like we are fighting against the stateless philosophy. Evaluate a potential redux replacement of authentication state
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the unit tests with yarn test to make sure you didn't break anything
Add or update any needed documentation to the repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
BUG:
You can test this on: https://beta.mobilitydatabase.org/
Reason: When the user opens the new tab on a non-legacy page, the redux store data is not initialized. So when the user goes to logout (from the header) the logout action clears nothing because the store isn't initialized
Fix: Initialize the redux store data from all pages without waiting on it to finish hydrating. The non-legacy pages will initialize the store data but it wont be ready until the client rehydrates it (potential bug - but low odds of it happening).
Also added some small fixes for best practices (image) and lighthouse url fix
Expected behavior:
User logs in -> user closes the browser tab -> user opens a new tab (any page) -> user goes to logout -> user is able to log back in
Testing tips:
Attempt the expected behaviour
Future
With SSR (stateless by design) handling Redux state feels like we are fighting against the stateless philosophy. Evaluate a potential redux replacement of authentication state
Please make sure these boxes are checked before submitting your pull request - thanks!
yarn testto make sure you didn't break anything