BLD,BUG: Add charset-normalizer to improve compatibility with non-ascii environments.#266
Open
BeiyanYunyi wants to merge 2 commits intoNCAR:developfrom
Open
BLD,BUG: Add charset-normalizer to improve compatibility with non-ascii environments.#266BeiyanYunyi wants to merge 2 commits intoNCAR:developfrom
BeiyanYunyi wants to merge 2 commits intoNCAR:developfrom
Conversation
Collaborator
|
Thanks for the PR! I'll take a look at this tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a system with a non-ascii compatible
LANGenvironment variable, gfortran will produce non-ascii output. My working environment is Linux withLANG=zh_CN.UTF-8, in my environment,will output:
instead of:
Chinese character at line 3 will cause the project fail to build:
To reproduce the bug, simply run this command in the repo (POSIX environment):
As
numpy.f2pysuggests,It is likely that installing charset_normalizer package will help f2py determine the input file encoding correctly.Addingcharset-normalizertobuild-system.requireswill make it infer the encoding correctly. After adding it tobuild-system.requires, I've successfully built this package.