You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR introduces a self-hosted C++ CI workflow that builds and tests the project inside a pinned nvcr.io/nvidia/cuda:12.6.3-devel-ubuntu22.04 container, along with a setup_dependencies.sh script that installs Miniforge and the required conda packages. The SHA-256 integrity check for the Miniforge installer has been added, resolving the prior security concern.
Confidence Score: 5/5
Safe to merge; all remaining findings are P2 style suggestions that do not block correct operation.
The previously flagged security concern (missing Miniforge checksum) is now resolved, the container image is pinned to a specific version, and the only new finding is an inconsistent -u flag in set options — a non-blocking style issue.
No files require special attention.
Important Files Changed
Filename
Overview
.github/workflows/cpp-build-test.yml
New self-hosted C++ CI workflow using a pinned CUDA 12.6.3 container; minor inconsistency in set flags (-u missing in Configure/Build/Test steps) and the CC/CXX compiler-selection issue discussed in prior threads remains unresolved.
admin/ci/setup_dependencies.sh
Installs Miniforge and conda packages; SHA-256 integrity check for the installer has been added (resolving the prior security finding); compiler CC/CXX exports have been removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.