fix: device plugin needs update rights to nodefeatures #2108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…estart Signed-off-by: Rajat Chopra <[email protected]>
rajatchopra
requested review from
ArangoGutierrez,
cdesiniotis,
karthikvetrivel,
shivamerla and
tariq1890
as code owners
tariq1890
reviewed
Feb 9, 2026
| - get | ||
| - list | ||
| - watch | ||
| - update |
Contributor
There was a problem hiding this comment.
Are you able to patch instead to update your NFD CRs ? update in general is a riskier operation as it is more sensitive to race conditions.
Contributor
Author
There was a problem hiding this comment.
No. The GFD seems to use the Update call:
E0210 20:21:14.746771 1 main.go:127] failed to update NodeFeature object "nvidia-features-for-dellr760tdx": nodefeatures.nfd.k8s-sigs.io "nvidia-features-for-dellr760tdx" is forbidden: User "system:serviceaccount:gpu-operator:nvidia-sandbox-device-plugin" cannot update resource "nodefeatures" in API group "nfd.k8s-sigs.io" in the namespace "gpu-operator"
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Got it. I meant updating the code to use patch instead of update
tariq1890
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the device plugin restarts, it will attempt to update the existing nodefeatures object
Also need to update the nodefeatures object for the 'gpu.count' label
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Manual testing