ensure the toolkit exits if NRI Plugin init fails#1780
Merged
Conversation
Coverage Report for CI Build 24482728641Coverage increased (+0.05%) to 43.32%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
tariq1890
force-pushed
the
nri-non-zero-exit-on-fail
branch
2 times, most recently
from
df06b66 to
620d173
Compare
tariq1890
changed the title
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
tariq1890
force-pushed
the
nri-non-zero-exit-on-fail
branch
from
620d173 to
bb852eb
Compare
cdesiniotis
approved these changes
Apr 15, 2026
Contributor
Author
|
/cherry-pick release-1.19 |
|
🤖 Backport PR created for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When enabling NRI plugin, the toolkit must require the NRI Plugin server connect to be successful. If not, it should terminate with a non-zero exit code. Currently, we only log an error if the NRI Plugin connect fails and let the toolkit run.
With this change, the retry block is no longer needed, as the NRI Plugin connect will be retried through a container restart