Add configurable bounds for hash-grid input dimensions#533
Closed
ayushozha wants to merge 1 commit intoNVlabs:masterfrom
Closed
Add configurable bounds for hash-grid input dimensions#533ayushozha wants to merge 1 commit intoNVlabs:masterfrom
ayushozha wants to merge 1 commit intoNVlabs:masterfrom
Conversation
2113b4f to
a88e66c
Compare
Collaborator
|
Thanks for the PR, however I'm not a fan of making this configurable in the first place. It's a lot of boilerplate for something the user could enable with a very simple patch file / fork of tcnn. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TCNN_HASH_MIN_DIMandTCNN_HASH_MAX_DIMbuild options for hash gridsWhy
Issue #422 asks for 5D grid support. The current hash-grid dispatch is hard-coded to a narrow range of input dimensions, so enabling 5D grids requires rebuilding the library. This change makes the supported hash-grid dimension range explicit and configurable at build time while preserving the existing defaults.
Validation
python -m py_compile bindings/torch/setup.pycmake -S . -B build-hash-dim-check -G Ninja -DTCNN_BUILD_TESTS=1 -DTCNN_HASH_MAX_DIM=5cmake --build build-hash-dim-check --target test_gridctest --output-on-failure -V -R test_gridCloses #422.