Use fastavro for avro encoding/decoding#45
Merged
yossariano merged 6 commits intomainfrom Jun 17, 2025
Merged
Conversation
charmingduchess
previously approved these changes
Jun 17, 2025
Contributor
charmingduchess
left a comment
There was a problem hiding this comment.
Smashing! I'd recommend a minor version bump to 1.7, rather than a patch bump.
danamansana
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fastavroshows considerable improvements overavroin our benchmarks. The following benchmark is comparing the current avro_encoder in nypl-python-utils with the one in this PR:schemaless_writerandschemaless_readerin this change. In my testing, using the standard fastavrowriterandreaderput headers onto the encoded data which didn't match the bytes of the unit test's expected data. In order to adhere to the existing tests (and presumably existing encoders/decoders) I opted to exclude the headers during encoding.