Skip to content

refactor(trie2): use more descriptive felt.Hash type instead of felt.Felt#3316

Merged
MaksymMalicki merged 7 commits intomainfrom
maksym/refactor-triedb-hash
Dec 11, 2025
Merged

refactor(trie2): use more descriptive felt.Hash type instead of felt.Felt#3316
MaksymMalicki merged 7 commits intomainfrom
maksym/refactor-triedb-hash

Conversation

@MaksymMalicki
Copy link
Copy Markdown
Contributor

@MaksymMalicki MaksymMalicki commented Nov 28, 2025

This PR addresses #3282 (comment), and uses more descriptive felt.Hash type for trie node hash fields and felt.StateRootHash for all the state root hash fields in all triedb and trie2 packages

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 68.49315% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.10%. Comparing base (55cfeb3) to head (275a9f2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
core/trie2/trie.go 28.57% 20 Missing ⚠️
core/felt/hash.go 33.33% 8 Missing ⚠️
core/trie2/trieutils/id.go 75.00% 6 Missing ⚠️
core/trie2/triedb/pathdb/journal.go 37.50% 5 Missing ⚠️
core/trie2/databasetest.go 70.00% 3 Missing ⚠️
core/trie2/trieutils/accessors.go 33.33% 2 Missing ⚠️
core/trie2/triedb/hashdb/database.go 94.11% 1 Missing ⚠️
core/trie2/triedb/rawdb/database.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3316      +/-   ##
==========================================
+ Coverage   76.09%   76.10%   +0.01%     
==========================================
  Files         347      347              
  Lines       32769    32829      +60     
==========================================
+ Hits        24934    24983      +49     
- Misses       6045     6060      +15     
+ Partials     1790     1786       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MaksymMalicki MaksymMalicki force-pushed the maksym/refactor-triedb-address branch 2 times, most recently from 9210f6f to 090e07a Compare December 3, 2025 17:59
@MaksymMalicki MaksymMalicki force-pushed the maksym/refactor-triedb-hash branch from ad10776 to 6bee396 Compare December 3, 2025 19:19
Base automatically changed from maksym/refactor-triedb-address to main December 4, 2025 05:22
@MaksymMalicki MaksymMalicki force-pushed the maksym/refactor-triedb-hash branch from 6a421db to 886e905 Compare December 5, 2025 11:49
@MaksymMalicki MaksymMalicki force-pushed the maksym/refactor-triedb-hash branch from 886e905 to 96d28a1 Compare December 5, 2025 13:13
Comment thread core/trie2/triedb/hashdb/database_test.go Outdated
Comment thread core/trie2/triedb/pathdb/layertree_test.go Outdated
Comment thread core/trie2/triedb/pathdb/layertree_test.go
Comment thread core/trie2/trie.go Outdated
Comment thread core/trie2/trie.go Outdated
Comment thread core/trie2/triedb/pathdb/layertree_test.go Outdated
Comment thread core/trie2/triedb/pathdb/layertree_test.go Outdated
Copy link
Copy Markdown
Contributor

@EgeCaner EgeCaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread core/trie2/trieutils/accessors.go Outdated
Comment thread core/trie2/triedb/pathdb/cache_test.go Outdated
Comment thread core/trie2/triedb/pathdb/cache_test.go Outdated
Comment thread core/trie2/triedb/pathdb/cache_test.go Outdated
Comment thread core/trie2/triedb/hashdb/database.go
Comment thread core/trie2/triedb/hashdb/database_test.go
Comment thread core/trie2/triedb/hashdb/database_test.go
Comment thread core/trie2/triedb/hashdb/database_test.go
Comment thread core/trie2/triedb/hashdb/database_test.go Outdated
Comment thread core/trie2/trieutils/accessors.go
@MaksymMalicki MaksymMalicki force-pushed the maksym/refactor-triedb-hash branch from 115da65 to 275a9f2 Compare December 10, 2025 16:52
@MaksymMalicki MaksymMalicki merged commit 6b9b358 into main Dec 11, 2025
31 of 34 checks passed
@MaksymMalicki MaksymMalicki deleted the maksym/refactor-triedb-hash branch December 11, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants