Skip to content

refactor(core): new pending pkg#3564

Merged
thiagodeev merged 3 commits intomainfrom
thiagodeev/new-pending-pkg
Apr 17, 2026
Merged

refactor(core): new pending pkg#3564
thiagodeev merged 3 commits intomainfrom
thiagodeev/new-pending-pkg

Conversation

@thiagodeev
Copy link
Copy Markdown
Contributor

@thiagodeev thiagodeev commented Apr 17, 2026

This PR moves the pending code in the core pkg into a new core/pending pkg.

Changes made:

  • copy/pasted of the pending code from core to core/pending;
  • renamed PendingState and PendingStateWriter to State and StateWriter since now the pkg prefix gives the context (e.g: pending.NewState instead of pending.NewPendingState;

@thiagodeev thiagodeev force-pushed the thiagodeev/new-pending-pkg branch from da08f8a to 4dff1ad Compare April 17, 2026 13:22
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 75.78125% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.74%. Comparing base (925371e) to head (691d69c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
adapters/sn2core/sn2core.go 20.00% 8 Missing ⚠️
core/pending/state.go 77.27% 5 Missing ⚠️
consensus/datasource/consensus_data_source.go 0.00% 4 Missing ⚠️
core/pending/pending.go 86.95% 3 Missing ⚠️
sync/sync.go 50.00% 3 Missing ⚠️
rpc/v8/subscriptions.go 0.00% 1 Missing and 1 partial ⚠️
sync/data_source.go 66.66% 2 Missing ⚠️
sync/helpers.go 66.66% 2 Missing ⚠️
builder/builder.go 90.00% 1 Missing ⚠️
starknetdata/feeder/feeder.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3564      +/-   ##
==========================================
+ Coverage   75.72%   75.74%   +0.02%     
==========================================
  Files         384      384              
  Lines       33757    33764       +7     
==========================================
+ Hits        25563    25576      +13     
  Misses       6398     6398              
+ Partials     1796     1790       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@EgeCaner EgeCaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Base automatically changed from thiagodeev/new-deprecated-state-pkg to main April 17, 2026 15:03
@thiagodeev thiagodeev force-pushed the thiagodeev/new-pending-pkg branch from 4dff1ad to 691d69c Compare April 17, 2026 15:31
@thiagodeev thiagodeev marked this pull request as ready for review April 17, 2026 15:32
@thiagodeev thiagodeev enabled auto-merge (squash) April 17, 2026 15:32
@thiagodeev thiagodeev merged commit 1364259 into main Apr 17, 2026
14 of 15 checks passed
@thiagodeev thiagodeev deleted the thiagodeev/new-pending-pkg branch April 17, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants