treewide: substitute pname for strings (pkgs/development/)#511828
Open
pbsds wants to merge 1 commit intoNixOS:masterfrom
Open
treewide: substitute pname for strings (pkgs/development/)#511828pbsds wants to merge 1 commit intoNixOS:masterfrom
pbsds wants to merge 1 commit intoNixOS:masterfrom
Conversation
repeat of NixOS#410679 for `pkgs/development/`, part of NixOS#346453
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
Contributor
|
None of the linked issues tell me the "why" of this change. What's the point, and why is it worth the churn? |
Member
Author
|
personally i don't care for this, but the amount of noise and round trips nitpick-able issues like this cause during reviews is reason enough for me to eliminate such copy-paste footguns from the tree |
Contributor
|
I don't understand how this change will reduce nitpicks. I can imagine equal numbers of reviewers asking for re-use of the pname versus statically defining it. |
Member
Author
|
it's only a small holistic nudge yes, but is that a blocker? |
Contributor
|
I’m neither blocking, nor approving, just discussing. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
repeat of #410679 for
pkgs/development/, part of #346453Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.