Skip to content

codex: build only codex and disable LTO to halve build time#511835

Merged
siraben merged 1 commit intoNixOS:masterfrom
siraben:siraben/codex-debug
Apr 20, 2026
Merged

codex: build only codex and disable LTO to halve build time#511835
siraben merged 1 commit intoNixOS:masterfrom
siraben:siraben/codex-debug

Conversation

@siraben
Copy link
Copy Markdown
Member

@siraben siraben commented Apr 20, 2026 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot requested review from delafthi, jeafleohj and malob April 20, 2026 19:04
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Apr 20, 2026
@delafthi
Copy link
Copy Markdown
Contributor

delafthi commented Apr 20, 2026

decreasing build time would be great. currenly, this package takes a crazy amount of time to build (for a cli). can you format your code? then i will run nixpkgs-review to check the build time.

@siraben
Copy link
Copy Markdown
Member Author

siraben commented Apr 20, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 511835
Commit: 2409eec921252ac3b7fd8ec5c2ddd2f7c8ad85ed

x86_64-linux

✅ 1 package built:
  • codex

@siraben siraben force-pushed the siraben/codex-debug branch from 2409eec to fd65fa0 Compare April 20, 2026 19:53
@siraben
Copy link
Copy Markdown
Member Author

siraben commented Apr 20, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 511835
Commit: 2409eec921252ac3b7fd8ec5c2ddd2f7c8ad85ed

aarch64-darwin

✅ 1 package built:
  • codex

@jeafleohj
Copy link
Copy Markdown
Contributor

jeafleohj commented Apr 20, 2026 •
edited
Loading

LGTM.

0.122.0 is available — given the reduced build time, would it make sense to include it here, or follow up with a separate bump?

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Apr 20, 2026
@siraben
Copy link
Copy Markdown
Member Author

siraben commented Apr 20, 2026

@jeafleohj I'll make it a separate PR.

@siraben siraben added this pull request to the merge queue Apr 20, 2026
Merged via the queue into NixOS:master with commit 4d3b60c Apr 20, 2026
33 checks passed
@siraben siraben deleted the siraben/codex-debug branch April 20, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delafthi delafthi Awaiting requested review from delafthi

@malob malob Awaiting requested review from malob

1 more reviewer

@jeafleohj jeafleohj jeafleohj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siraben @delafthi @jeafleohj