-
-
Notifications
You must be signed in to change notification settings - Fork 539
[18.0][MIG] base_export_async: migrate #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
…achment to a record only visible to the user
Currently translated at 100.0% (19 of 19 strings) Translation: queue-12.0/queue-12.0-base_export_async Translate-URL: https://translation.odoo-community.org/projects/queue-12-0/queue-12-0-base_export_async/de/
Currently translated at 100.0% (19 of 19 strings) Translation: queue-12.0/queue-12.0-base_export_async Translate-URL: https://translation.odoo-community.org/projects/queue-12-0/queue-12-0-base_export_async/zh_Hans/
The UI still send it to the current user, but it will allow reusing the module for other purposes: plan a regular export to users. Setting the recipient_ids instead of the email_to in mail.mail means that we can still send the email, it will stay in the failed emails, allowing to correct the user.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: queue-12.0/queue-12.0-base_export_async Translate-URL: https://translation.odoo-community.org/projects/queue-12-0/queue-12-0-base_export_async/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: queue-15.0/queue-15.0-base_export_async Translate-URL: https://translation.odoo-community.org/projects/queue-15-0/queue-15-0-base_export_async/
Currently translated at 100.0% (22 of 22 strings) Translation: queue-16.0/queue-16.0-base_export_async Translate-URL: https://translation.odoo-community.org/projects/queue-16-0/queue-16-0-base_export_async/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: queue-16.0/queue-16.0-base_export_async Translate-URL: https://translation.odoo-community.org/projects/queue-16-0/queue-16-0-base_export_async/
Currently translated at 100.0% (22 of 22 strings) Translation: queue-16.0/queue-16.0-base_export_async Translate-URL: https://translation.odoo-community.org/projects/queue-16-0/queue-16-0-base_export_async/it/
Currently translated at 100.0% (22 of 22 strings) Translation: queue-16.0/queue-16.0-base_export_async Translate-URL: https://translation.odoo-community.org/projects/queue-16-0/queue-16-0-base_export_async/it/
Currently translated at 100.0% (22 of 22 strings) Translation: queue-16.0/queue-16.0-base_export_async Translate-URL: https://translation.odoo-community.org/projects/queue-16-0/queue-16-0-base_export_async/fr/
As normal user only have read access to delay.export, we need sudo to chreate an attachment on this record Use user 6 (Marc Demo) in the tests, not admin (2)
49b1330 to
af3b019
Compare
af3b019 to
f02ebf1
Compare
samirGuesmi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @pierre-halleux
Thanks for the PR! 👍 😄
There’s just a small adjustment I’d suggest to avoid the following issue:
TypeError: this.env._t is not a function
| async onClickExportButton() { | ||
| if (!this.state.exportList.length) { | ||
| return this.notification.add( | ||
| this.env._t("Please select fields to save export list..."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| this.env._t("Please select fields to save export list..."), | |
| _t("Please select fields to save export list..."), |
| type: field.field_type || field.type, | ||
| })); | ||
| if (import_compat) { | ||
| exportedFields.unshift({name: "id", label: this.env._t("External ID")}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| exportedFields.unshift({name: "id", label: this.env._t("External ID")}); | |
| exportedFields.unshift({name: "id", label: _t("External ID")}); |
No description provided.