[18.0][ADD] report_positioned_image by kanda999 · Pull Request #1138 · OCA/reporting-engine

kanda999 · 2026-02-26T10:50:26Z

kanda999 · 2026-03-04T10:16:35Z

report_positioned_image/models/ir_actions_report.py

+<script>
+var page = window.location.search.match(/[?&]page=(\\d+)/);
+if (page && parseInt(page[1]) > 1) {{
+  var elements = document.getElementsByClassName('{css_class}');
+  for (var i = 0; i < elements.length; i++) {{
+    elements[i].style.display = 'none';
+  }}
+}}
+</script>
+"""


Is it unavoidable to use JS?

AungKoKoLin1997 · 2026-03-09T04:34:45Z

Tests CI is fixed at #1142.

yostashiro

Functional test. 'First Page Only' option doesn't seem to be working.

yostashiro · 2026-03-09T07:09:43Z

report_positioned_image/__manifest__.py

+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+{
+    "name": "Report Positioned Image",
+    "summary": "Add positioned images to PDF reports generated by Odoo.",


Suggested change

"summary": "Add positioned images to PDF reports generated by Odoo.",

"summary": "Add positioned images to PDF reports",

yostashiro · 2026-03-12T04:38:24Z

report_positioned_image/models/__init__.py

+# Copyright 2026 Quartile
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+


Suggested change

# Copyright 2026 Quartile

# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

yostashiro · 2026-03-12T05:14:54Z

report_positioned_image/models/res_company.py

+class ResCompany(models.Model):
+    _inherit = "res.company"
+
+    report_positioned_image_ids = fields.Many2many(


I think this should be one2many. It looks inconsistent with how company_id is defined as many2one in report.positioned.image.

I intentionally avoid using a One2many field because it can lead to unintended behavior.

For example, when we add a positioned image to an Order/Quotation report for a specific company, that image is also assigned to the company’s report images. As a result, every time we create a positioned image for a specific report, all of those images are added to the company as well.

Then, if we remove the report images from the company, they are also unlinked from the specific report, which is not the intended behavior.

Okay, we may add a help text to company_id of the image model to make the intent clear.

yostashiro · 2026-03-12T05:16:38Z

report_positioned_image/models/ir_actions_report.py

+class IrActionsReport(models.Model):
+    _inherit = "ir.actions.report"
+
+    include_company_report_image = fields.Boolean(


Suggested change

include_company_report_image = fields.Boolean(

include_company_images = fields.Boolean(

I wanted to include report to make the purpose clearer, but I think include_company_images is already enough. So I updated it.

yostashiro · 2026-03-12T05:25:51Z

report_positioned_image/security/ir.model.access.csv

@@ -0,0 +1,4 @@
+id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
+access_report_positioned_image_portal,report.positioned.image portal,model_report_positioned_image,base.group_portal,1,0,0,0


This one doesn't look necessary. Please confirm.

Suggested change

access_report_positioned_image_portal,report.positioned.image portal,model_report_positioned_image,base.group_portal,1,0,0,0

access_report_positioned_image_portal,report.positioned.image

I initially thought that portal users would need access to the model.
After verifying the behavior, I confirmed that this is not necessary because _show_report in the portal runs with sudo().

AungKoKoLin1997 · 2026-03-12T08:56:15Z

'First Page Only' option doesn't seem to be working.

@yostashiro For some reason, my latest code changes are not reflected in this PR.

In my update, I added report_qweb_element_page_visibility as a dependency to improve the usability of the first-page feature.

yostashiro · 2026-03-12T14:07:51Z

report_positioned_image/models/report_positioned_image.py

+    first_page_only = fields.Boolean()
+    company_id = fields.Many2one(
+        comodel_name="res.company",
+        required=True,


Can we remove this required=True? I think it will allow more flexible use of the images. We should also add a record rule for this model.

AungKoKoLin1997 force-pushed the 18.0-add-report_positioned_image branch from 9cdb5c7 to 008cb16 Compare March 4, 2026 03:59

kanda999 commented Mar 4, 2026

View reviewed changes

AungKoKoLin1997 force-pushed the 18.0-add-report_positioned_image branch 2 times, most recently from 87ba8b0 to c6135ae Compare March 5, 2026 08:42

kanda999 marked this pull request as ready for review March 9, 2026 02:01

AungKoKoLin1997 force-pushed the 18.0-add-report_positioned_image branch from c6135ae to 8749993 Compare March 9, 2026 02:16

AungKoKoLin1997 force-pushed the 18.0-add-report_positioned_image branch 2 times, most recently from a1d9344 to 7a887ff Compare March 10, 2026 08:08

yostashiro suggested changes Mar 12, 2026

View reviewed changes

yostashiro reviewed Mar 12, 2026

View reviewed changes

[ADD] report_positioned_image

0b84ccf

AungKoKoLin1997 force-pushed the 18.0-add-report_positioned_image branch from 7a887ff to 0b84ccf Compare March 12, 2026 08:55

yostashiro reviewed Mar 12, 2026

View reviewed changes

	"summary": "Add positioned images to PDF reports generated by Odoo.",
	"summary": "Add positioned images to PDF reports",

		# Copyright 2026 Quartile
		# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

	include_company_report_image = fields.Boolean(
	include_company_images = fields.Boolean(

		@@ -0,0 +1,4 @@
		id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
		access_report_positioned_image_portal,report.positioned.image portal,model_report_positioned_image,base.group_portal,1,0,0,0

Uh oh!

Conversation

kanda999 commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AungKoKoLin1997 commented Mar 9, 2026

Uh oh!

yostashiro left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AungKoKoLin1997 Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AungKoKoLin1997 commented Mar 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kanda999 commented Feb 26, 2026 •

edited

Loading

AungKoKoLin1997 Mar 12, 2026 •

edited

Loading