[19.0][MIG][WIP] server_environment_ir_config_parameter: Migration to 19.0#248
Conversation
lembregtse
changed the title
lembregtse
changed the title
lembregtse
force-pushed
the
19.0-mig-server_environment_ir_config_parameter
branch
from
922146b to
0aecaa6
Compare
FrancoMaxime
left a comment
FrancoMaxime
left a comment
There was a problem hiding this comment.
LGTM: code review & functionnal review
|
/ocabot migration server_environment_ir_config_parameter |
|
@lembregtse Can you remove the test dependency so we can merge your PR? |
|
A kind reminder to remove dependency. Thank you |
|
Hello @lembregtse Could you check the comments and maybe rebase your PR ? Thanks a lot |
AnizR
left a comment
AnizR
left a comment
There was a problem hiding this comment.
Thanks for your work 🚀
This PR has been widely approved.
Can we remove the commit "[DON'T MERGE] test-requirements.txt" ?
… values This is much more robust that raising an error, and let modules load ir.config_parameter from xml data files, while still enforcing values from the config files.
Odoo loads modules that contain static directory, so it wanted to load server_environment_files but it does not exist
Without this sudo get_param would fail when the first user reading a parameter that has changed in the configuration file does not have write access to system parameters.
Manual forward port of 11.0 migration commit by Thierry Ducrest.
…arameter list and form views the new field is_environment, and make the key and values readonly if checked
fix a conflict between this module and mail which overrides the reading of some mail related system parameters
Currently translated at 100.0% (4 of 4 strings) Translation: server-env-16.0/server-env-16.0-server_environment_ir_config_parameter Translate-URL: https://translation.odoo-community.org/projects/server-env-16-0/server-env-16-0-server_environment_ir_config_parameter/es/
…tributes in XML view
Currently translated at 100.0% (4 of 4 strings) Translation: server-env-17.0/server-env-17.0-server_environment_ir_config_parameter Translate-URL: https://translation.odoo-community.org/projects/server-env-17-0/server-env-17-0-server_environment_ir_config_parameter/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-env-18.0/server-env-18.0-server_environment_ir_config_parameter Translate-URL: https://translation.odoo-community.org/projects/server-env-18-0/server-env-18-0-server_environment_ir_config_parameter/
rven
force-pushed
the
19.0-mig-server_environment_ir_config_parameter
branch
from
0aecaa6 to
e6d0d4c
Compare
|
ping @lembregtse :) |
|
This PR has the |
|
Hello @OCA/tools-maintainers can you pls take a look at this PR and possibly merge? |
|
/ocabot migration server_environment_ir_config_parameter /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 679fca3. Thanks a lot for contributing to OCA. ❤️ |
20 participants
We still want to improve to create a seperate config section for running_env.